Repository navigation
release: 0.49.0 #64
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| ".": "0.49.0" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| [project] | ||
| name = "sentdm" | ||
| version = "0.49.0" | ||
|
There was a problem hiding this comment. 🟣 pre-existing, not blocking: After merge, uv.lock still says 0.48.0, so the next generator run will cut a 0.50.0 release that changes nothing for customers. This release bumps pyproject.toml, .release-please-manifest.json and _version.py, but not the Why this was flaggedThis diff changes pyproject.toml:3 to Verification: Trigger: the next generator (stlc-bot) sync runs after this merges. The diff does not touch |
||
| description = "The official Python library for the Sent API" | ||
| dynamic = ["readme"] | ||
| license = "Apache-2.0" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # File generated from our OpenAPI spec by Stainless. See CONTRIBUTING.md for details. | ||
|
|
||
| __title__ = "sent_dm" | ||
| __version__ = "0.49.0" # x-release-please-version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Customers get a 0.49.0 minor release with a Features line, "sync generated SDKs from the committed spec", that changes nothing they can see. The only commit in range, 5f13955, uses a
feat(api):type but only bumps the editablesentdmversion in uv.lock from 0.47.0 to 0.48.0. That type cuts a release, and its subject describes an internal pipeline step, not a customer-visible change. Fix: don't publish this release. Have the SDK pipeline use a hidden type such asci:ortest:for lockfile-only syncs, and savefeat(api):subjects for real API changes. Close this release PR, or override its notes, until a customer-visible change lands.Why this was flagged
The range 5f13955..HEAD holds one commit,
feat(api): sync generated SDKs from the committed spec(Stainless-Generated-From 912e2ca). It touches only uv.lock, where thesentdmeditable package version moves from "0.47.0" to "0.48.0". There is no API, model or client change. release-please treatsfeat:as releasable, so this PR bumps pyproject.toml, src/sent_dm/_version.py and .release-please-manifest.json to 0.49.0. It also adds CHANGELOG.md:8, which tells customers there is a new feature but names an internal process (a spec sync) and nothing they can use. Merging the release PR publishes 0.49.0 to PyPI, so customers get an empty minor release. REVIEW.md lists as Important "a type that cuts a release for a change customers don't see" and "an internal cause". CLAUDE.md says the subject must be written for customers, "Never an internal cause". The same pattern already shipped twice in 0.48.0, so it is recurring, not a one-off.Verification: The trigger is merging this release PR, which publishes 0.49.0. The diff adds this line at CHANGELOG.md:8 under "### Features": "* api: sync generated SDKs from the committed spec (5f13955)". 5f13955, the only commit since v0.48.0, changes only uv.lock: the editable
sentdmversion goes from 0.47.0 to 0.48.0. It changes no API, model or client code, so customers get nothing new.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest push brings this issue back at
CHANGELOG.md:9:🔴 Customers get a new 0.49.0 Features line about CI topology, an internal build detail they can neither see nor use. It comes from commit ca4dccc, typed
feat(ci):. That commit only edits an echo line in scripts/utils/upload-artifact.sh. Afeattype puts it in the changelog, whileci:would hide it. Fix: give CI-only generated commits a hidden type (ci:) in the SDK configuration, then regenerate this release so CHANGELOG.md drops the line. This differs from the posted 5f13955/uv.lock finding: that fix leaves this line in place.Why this was flagged
The trigger is merging this release PR, which publishes 0.49.0 with the CHANGELOG.md:9 entry "* ci: run every SDK on the one-repo topology (ca4dccc)" under "### Features". Commit ca4dccc changes one line in scripts/utils/upload-artifact.sh: the pip install URL that the CI upload step echoes moves from
sent-dm-python-stagingtosent-dm-python. It does not touch the API, models or client. CLAUDE.md says "ci:andtest:are hidden from the changelog" and that a subject must be written for customers, "Never an internal cause". REVIEW.md lists "a type that cuts a release for a change customers don't see" as Important. On the base branch the changelog has no such line. The existing [PRIOR] finding covers only the 5f13955 line at CHANGELOG.md:8 and its uv.lock cause. Fixing that leaves this line in place, because thefeattype on ca4dccc still makes it releasable and visible.Verification: Trigger: merging this release PR, which publishes 0.49.0 with its changelog. The diff adds CHANGELOG.md:9 under "### Features": "* ci: run every SDK on the one-repo topology (ca4dccc)".
git show ca4dccctouches only scripts/utils/upload-artifact.sh (1 insertion, 1 deletion). Only"type": "ci"is"hidden": true, so thefeat(ci):type is what surfaces the line.