Add pause functionality to Sample#330
Merged
Merged
Conversation
Contributor
Author
|
I haven't tested it yet, so a draft for now. |
Collaborator
|
Hi, |
positron96
marked this pull request as ready for review
July 18, 2026 22:17
Contributor
Author
|
ok, seems to work in simple tests |
tomcombriat
reviewed
Jul 19, 2026
tomcombriat
left a comment
tomcombriat
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thanks!
Just added a small optimization comment, otherwise, except if the others have some comments, will merge in a few day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds pause/unpause functionality for Sample.
Closes #329.