Skip to content

Disable implicit join output row cap - #2076

Merged
justinjoy merged 1 commit into
mainfrom
codex/1369-audit
Oct 4, 2026
Merged

justinjoy merged 1 commit into
mainfrom
codex/1369-audit

Conversation

@justinjoy

Copy link
Copy Markdown
Collaborator

Summary

  • Disable the physical-RAM-derived join row cap when WIRELOG_JOIN_OUTPUT_LIMIT is unset, empty, or zero.
  • Preserve explicit positive decimal caps, clamp them to UINT32_MAX, and reject malformed or overflowing values before acquiring session resources.
  • Update memory-policy documentation and add tests for defaults, invalid values, retry, clamp boundaries, worker configuration, and high-water accounting.

This is the implicit row-cap portion of #1369. It does not close #1369; remaining allocation classes are still tracked there and in follow-up work.

Validation

  • test_join_limit: 8/8
  • join_overflow, memory_admission_join, k_fusion_correctness, tdd_multiworker, join_batch_resume, session, session_admission, session_options, wirelog_public_api, worker_session: passed
  • ABI checks: public header surface, public API macro, public API exports passed
  • uncrustify --check on changed C files and git diff --check: passed

Binary-size policy remains informational until a stable version is declared.

@justinjoy
justinjoy merged commit 3134289 into main Oct 4, 2026
30 checks passed
@justinjoy
justinjoy deleted the codex/1369-audit branch October 4, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce memory admission at every allocation class; replace the join row cap and deprecate WIRELOG_JOIN_OUTPUT_LIMIT

1 participant