build(deps): bump pypa/cibuildwheel from 4.2.0 to 4.2.1 - #190
Merged
Merged
Conversation
Bumps pypa/cibuildwheel from v4.2.0 to v4.2.1 in the release and wheels workflows, redoing #189 with the one change Dependabot cannot make. test_wheel_workflows_use_cibuildwheel_v4_2_0 pins the exact cibuildwheel version both wheel-building workflows must use, so the bump has to update that guard in lockstep. Dependabot cannot touch the test, which is why #189 failed all twelve test-matrix jobs on that single assertion while lint passed. #185 failed the same way before the 4.1.1 to 4.2.0 bump was redone by hand in 9fc85d9. The guard is renamed to match the version it now asserts, and v4.2.0 joins the list of superseded versions the workflows must not fall back to. v4.2.1 is a patch release: it respects machine-configured NuGet sources when installing CPython on Windows, fixes a NameError on Pyodide when an already-compatible wheel is reused, updates the Android testbed for Java 25, and refreshes dependencies including CPython 3.15.0rc2. None of it reaches this wheel matrix -- `tool.cibuildwheel.build` enumerates cp311 through cp314 explicitly, `skip` excludes PyPy and musllinux, and neither Pyodide nor Android is built here. The Windows NuGet change is the only item with live exposure, so wheels.yml is dispatched on the branch to exercise it; neither wheel workflow runs on pull_request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #189.
Why #189 could not merge
Dependabot opened #189 to bump
pypa/cibuildwheelfrom v4.2.0 to v4.2.1 inthe two wheel-building workflows.
lintpassed and all twelve test-matrixjobs failed, every one of them on a single assertion:
test_wheel_workflows_use_cibuildwheel_v4_2_0pins the exact cibuildwheelversion both workflows must use. Dependabot cannot edit tests, so the pin and
the guard drift apart on every cibuildwheel bump. #185 failed the same way
before the 4.1.1 -> 4.2.0 bump was redone by hand in 9fc85d9.
What this PR does
The workflow edits here are byte-identical to Dependabot's commit 45ae699,
plus the guard update Dependabot could not make:
.github/workflows/wheels.ymlpypa/cibuildwheel@v4.2.0->@v4.2.1.github/workflows/release.ymlpypa/cibuildwheel@v4.2.0->@v4.2.1tests/test_wheels_config.py..._v4_2_1, positive assert flipped, v4.2.0 added to the superseded listThree files, +5/-4 - the same shape as precedent 9fc85d9.
No CHANGELOG entry:
tests/test_changelog_format.py::test_unreleased_section_is_empty_for_100_releaserequires the Unreleased section stay byte-for-byte empty, and this repo records
CI action bumps at release time inside the dated section.
Upstream risk (v4.2.1)
NameErroron Pyodide when reusing a compatible wheel (#2968)skipexcludes PyPy/musllinux, no Pyodide targettool.cibuildwheel.buildenumerates cp311-cp314 explicitlyVerification
Neither
wheels.ymlnorrelease.ymlruns onpull_request- both trigger onlyon
v*tags andworkflow_dispatch. A green check here therefore proves theworkflow pin matches the guard, but proves nothing about cibuildwheel v4.2.1
actually building a wheel.
wheels.ymlis dispatched once on this branch tocover that; its
build_wheelsjob is byte-identical torelease.yml's, so onerun validates both.
Local: full suite
653 passed, 9 skipped, coverage 94.02%.black --check,isort --check-only,flake8,mypy src/pyrewireall clean.