test(flatkv): increase docker ci coverage#3417
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3417 +/- ##
==========================================
- Coverage 59.25% 59.25% -0.01%
==========================================
Files 2110 2112 +2
Lines 174181 174456 +275
==========================================
+ Hits 103210 103368 +158
- Misses 62044 62135 +91
- Partials 8927 8953 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
00487ef to
10c93b3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00487eff98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…verage `seidb import-flatkv-from-memiavl` copies a memiavl module (evm only) into FlatKV at a given height. Adds the CLI + translator, KVImporter Abort/Close-idempotent for partial-commit safety, unit tests for the concurrency pipeline + a 50K-pair E2E, and a docker CI job asserting post-import RPC reads match pre-import values. Offline DR / test-seeding tool only; does NOT exercise the MigrationManager (V0 -> V1) production path, and the post-import smoke is RPC-sample-level not a full set comparison. Co-authored-by: Cursor <cursoragent@cursor.com>
10c93b3 to
0414b90
Compare
…ash recovery - verify_statesync_flatkv_digest.sh: donor↔rpc-node dump-flatkv sha256 match at a chain height both nodes have committed, replacing the existing height-only state-sync probe. - verify_cross_validator_flatkv_digest.sh: all 4 validators must agree on flatkv physical content at a common committed chain height, catching silent drift the AppHash path cannot. - verify_flatkv_crash_recovery.sh: SIGKILL a validator mid block production, restart it, wait for catch-up, then 4-way digest match at a common committed chain height. - Wire the first two into the GIGA "Chain Operation Test" job; add a new GIGA "FlatKV Crash Recovery" job for the SIGKILL test. Compares via chain height + dump-flatkv WAL-replay (which works regardless of flatkv SnapshotInterval) rather than intersecting flatkv snapshot dirs, so the checks remain meaningful on CI devnets that never reach the default SnapshotInterval=10000 block boundary.
0414b90 to
f46dc25
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9c11f02. Configure here.
ab3edcd to
f89deef
Compare
f89deef to
c59c4dc
Compare

Summary
Expands docker-level FlatKV coverage across lattice-enabled, post-import, crash, state-sync, and local data-loss recovery paths. Adds an offline
seidb import-flatkv-from-memiavlpath that rebuilds FlatKV EVM state from memiavl, hardens the FlatKV importer against partial finalization, and he import command is a DR / test-seeding primitive; it preserves the productionMigrationManagerrollout boundary instead of replacing it.sei-db/tools/cmd/seidb/operations/import_flatkv_from_memiavl.go: introducesimport-flatkv-from-memiavl. It accepts onlyevm, rejects stale or future heights relative tomemiavl.GetLatestVersion, refuses to overwrite committed FlatKV without--force, passes source module names toAddModule, polls importer errors between exporter reads, and aborts on failure so partial imports never finalize or write a snapshot.sei-db/tools/cmd/seidb/main.go: registers the import command underseidb.sei-db/state_db/sc/flatkv/import_translator.go: addsImportTranslator, which maps memiavl changesets into FlatKV physical rows. It routes storage/code/legacy/non-EVM keys, buffers nonce/codehash account fragments across batches, emits one merged account row per address onFinalize, and returnsErrImportTranslatorFinalizedafter finalization.sei-db/state_db/sc/flatkv/importer.go: makesKVImporter.Closeidempotent, addsAbort(reason)to drain withoutFinalizeImport/WriteSnapshot, exposesErr()for fail-fast callers, and stores the test flush hook throughatomic.Pointerto avoid future race-detector failures.sei-db/state_db/sc/flatkv/wal_torn_write_test.go: adds flatkv-level WAL torn-write recovery coverage. It proves corrupted trailing WAL entries are discarded, clean WAL tails replay to the last appended commit, and recovered LtHash matches the last durable state.integration_test/contracts/deploy_flatkv_evm_fixture.sh: deploys an EVM fixture and persists expected balance, storage, code, and missing-key observations for pre/post import RPC checks.integration_test/contracts/import_flatkv_evm_cluster.sh: stops the devnet, imports EVM state into FlatKV on every validator, restarts in post-importdual_writewithevm-ss-split=falseandsc-enable-lattice-hash=false, and gates subsequent checks on block progress plus EVM RPC readiness.integration_test/contracts/verify_cross_validator_flatkv_digest.sh: assertssc-enable-lattice-hash=truein the from-genesis GIGA path and compares all FlatKV buckets (account,code,storage,legacy) at a shared committed height usingdump-flatkv --heightWAL replay.integration_test/contracts/verify_statesync_flatkv_digest.sh: asserts lattice hash is enabled and compares donor vs state-sync receiver full-bucket FlatKV digests at a shared committed height.integration_test/contracts/verify_flatkv_crash_recovery.sh: SIGKILLs one validator, verifies survivor progress, restarts the process, waits for catch-up, and compares canonical EVM buckets (account,code,storage) in the post-import lattice-disabled path.integration_test/contracts/verify_flatkv_statesync_crash_recovery.sh: wipes one validator, starts state-sync, injects a SIGKILL during restore, restarts, waits for catch-up, and verifies canonical EVM bucket parity.integration_test/contracts/verify_flatkv_total_loss_recovery.sh: simulates total local state loss, restores the validator via state-sync while preserving validator signing state, and verifies canonical EVM bucket parity.integration_test/contracts/verify_flatkv_partial_loss_fails_loudly.sh: deletes only the FlatKV directory and requires either a clear startup failure or a fully self-healed canonical EVM digest match.integration_test/contracts/verify_flatkv_evm_store.sh: dumps the storage bucket, verifies the fixture contract row, and documents the expected 41-byte serialized storage value layout.integration_test/seidb/flatkv_evm_test.yaml: verifies historical and latest EVM balance, storage, and code reads before and after import, checks missing account/storage behavior, and confirms non-EVM modules remain queryable.integration_test/contracts/AGENTS.md: documents the shared FlatKV Integration CI row, step ordering, destructive-test self-healing requirements, and the distinction between lattice-enabled full-bucket checks and post-import canonical EVM checks..github/workflows/integration-test.yml: keeps FlatKV-specific docker coverage under oneFlatKV Integrationrow and appends crash, state-sync crash, total-loss, and partial-loss scenarios after import verification. It also runs full-bucket lattice-enabled digest checks insideChain Operation Test.sei-db/state_db/sc/migration/OPERATIONS.md: documents the MigrateEVM operational model, non-atomic memiavl/FlatKV write risks, failure modes, detection signals, recovery paths, and future tooling roadmap.Test plan
sei-db/state_db/sc/flatkv/importer_test.go: coversCloseidempotency on success and error, first-error-wins semantics, non-blockingAddNodeafterdone, multi-flush large imports, abort-without-finalize behavior, abort after close, and explicit backpressure through the atomic flush hook.sei-db/state_db/sc/flatkv/import_translator_test.go: covers nil/empty changesets, storage/code/legacy/non-EVM routing, nonce and codehash buffering, same-call and cross-call account merges, delete dropping, malformed key/value rejection, mixed storage/account batches,Finalizeidempotency, and theTranslateafterFinalizesentinel error.sei-db/state_db/sc/flatkv/wal_torn_write_test.go: covers mid-record truncation, partial length-prefix truncation, and clean WAL tails, asserting recovery to the last good version or replay to the last clean WAL commit with LtHash consistency.sei-db/tools/cmd/seidb/operations/import_flatkv_from_memiavl_test.go: covers end-to-end EVM encoding through the CLI path,--forceoverwrite safety, height range checks, stale-height and future-height rejection, untouched FlatKV on rejection, and a large dataset that exercises importer flushes, worker backpressure, and cross-batch account merging.Chain Operation Testverifiessc-enable-lattice-hash=true, state-sync donor/receiver full-bucket digest equality, and cross-validator full-bucket digest equality at committed heights.FlatKV Integrationverifies fixture RPC reads before and after offline import, physical storage layout, SIGKILL restart recovery, state-sync mid-flight crash recovery, total-loss state-sync recovery, and FlatKV-only partial-loss failure behavior with diagnostic log dumps on failure.Note
Medium Risk
Medium risk because it changes FlatKV import finalization/lifecycle behavior (adds
Abort, makesCloseidempotent) and adds new migration/import translation logic that affects how EVM state is bulk-imported; issues could leave nodes with partially imported state if misused.Overview
Expands Docker CI coverage for FlatKV correctness and recovery. The integration workflow now runs new FlatKV digest checks after state-sync and adds an umbrella
FlatKV Integrationjob that exercises offline EVM migration to FlatKV, post-migration EVM historical queries, crash recovery, and multiple destructive disaster-recovery scenarios.Adds an offline EVM migration/import path and stronger validation. Introduces a new
seidb import-flatkv-from-memiavlcommand plus aflatkv.ImportTranslatorthat converts memiavl EVM changesets into FlatKV’s physical layout (with unit tests), and adds extensive importer lifecycle tests (fail-fastErr(), idempotentClose, andAbortto prevent finalizing partial imports).Improves FlatKV robustness testing. Adds a WAL torn-write regression test and new scripts/YAML to generate an EVM fixture and verify FlatKV bucket layout and cross-node/state-sync digest equality.
Reviewed by Cursor Bugbot for commit c59c4dc. Bugbot is set up for automated code reviews on this repo. Configure here.