Skip to content

docs: fix Prometheus README snippet, remove nonexistent NewHandler() #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinburkesegment merged 1 commit into from
Sep 9, 2026
Merged

docs: fix Prometheus README snippet, remove nonexistent NewHandler() #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,11 +197,14 @@ import (
"github.com/segmentio/stats/v5/prometheus"
)

handler := prometheus.NewHandler()
stats.Register(handler)
http.Handle("/metrics", handler)
stats.Register(prometheus.DefaultHandler)
http.Handle("/metrics", prometheus.DefaultHandler)
```

`Handler` has no `NewHandler` constructor; `DefaultHandler` is a ready-to-use zero-config
instance. Construct your own `&prometheus.Handler{}` literal instead if you need to set
`TrimPrefix`, `MetricTimeout`, or `Buckets`.

### InfluxDB

The [github.com/segmentio/stats/v5/influxdb](https://godoc.org/github.com/segmentio/stats/v5/influxdb) package sends metrics to InfluxDB using the line protocol over HTTP.
Expand Down
Loading