Repository navigation
Reset object tables and types too - #13
Merged
Merged
Conversation
USER_TABLES does not list object tables (CREATE TABLE ... OF some_type); only USER_OBJECT_TABLES / USER_ALL_TABLES do, while the dialect's reflection sees them like any other table. So one such leftover -- the driver's integration suite creates PYORACLE_AREF_PEOPLE OF PYORACLE_AREF_T when it shares the schema -- survived a reset and failed 41 ComponentReflectionTest cases that compare the whole table set, for a reason that looked like a driver bug. Two more kinds: object tables after the plain ones, and the types they are built on after them (a type in use by a table will not drop; FORCE first for a type referenced by another type, then the plain spelling). A backend without those dictionary views -- the Mirror over PostgreSQL -- reports them unavailable and carries on, as for the others. Verified on 11g: a planted object table + type and the driver suite's own leftovers, 8 of 8 dropped, nothing left in USER_OBJECTS; the Mirror-over-PG path still lists its plain tables. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USER_TABLESdoes not list object tables (CREATE TABLE ... OF some_type) — onlyUSER_OBJECT_TABLES/USER_ALL_TABLESdo — while the dialect's reflection (ALL_TABLES) sees them like any other table. So one such leftover survived a reset and failed 41ComponentReflectionTestcases that compare the whole table set, for a reason that looked like a driver bug. (The driver's integration suite createsPYORACLE_AREF_PEOPLE OF PYORACLE_AREF_Twhen it shares the schema.)The reset gains two kinds, in dependency order: object tables after the plain ones, then the types they are built on (
DROP TYPE … FORCE, then the plain spelling). A backend without those dictionary views — the Mirror over PostgreSQL — reports them unavailable and carries on, as for the others.Verified on 11g: a planted object table + type and the driver suite's own leftovers, 8 of 8 dropped,
USER_OBJECTSempty afterwards; the Mirror-over-PG path still lists its plain tables.ruff check/ruff format --checkclean.🤖 Generated with Claude Code