Skip to content

Fix init-submodules-release.sh#765

Merged
fabianbs96 merged 4 commits intodevelopmentfrom
f-FixInitSubmodulesRelease
Mar 24, 2025
Merged

Fix init-submodules-release.sh#765
fabianbs96 merged 4 commits intodevelopmentfrom
f-FixInitSubmodulesRelease

Conversation

@fabianbs96
Copy link
Copy Markdown
Member

See #759.

@fabianbs96 fabianbs96 requested a review from MMory as a code owner March 16, 2025 19:42
@fabianbs96 fabianbs96 linked an issue Mar 16, 2025 that may be closed by this pull request
@fabianbs96 fabianbs96 requested review from sritejakv and removed request for MMory March 22, 2025 11:16
@fabianbs96 fabianbs96 merged commit d294b68 into development Mar 24, 2025
8 checks passed
@fabianbs96 fabianbs96 deleted the f-FixInitSubmodulesRelease branch March 24, 2025 18:20
@kozeliv-zxc
Copy link
Copy Markdown

Hi, I think the command on line 15 should be
safe_cd json-schema-validator since it is actually checking out 2.3.0 in json-schema-validator external library, not json.

@fabianbs96
Copy link
Copy Markdown
Member Author

Hi @kozeliv-zxc, yes, that's indeed a mistake.
I opened a PR #826. Can you check, whether it fixes the issue on your side?

@kozeliv-zxc
Copy link
Copy Markdown

Yes, the new patch from #826 fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken init-submodule-release.sh

3 participants