Fix undefined symbol link error in llcorehttp#6021
Open
nibbbl wants to merge 1 commit into
Open
Conversation
These static consts in `HttpStatus` were not actually defined, but have been working by luck --fails on Xcode 26.6 and maybe some other toolchains?
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes intermittent undefined-symbol linker failures in llcorehttp by providing proper out-of-class definitions for HttpStatus’s static const error-source discriminator members, ensuring the expected symbols are emitted across toolchains (notably newer Xcode).
Changes:
- Replace mistaken namespace-scope variables with correctly qualified
HttpStatus::EXT_CURL_EASY,HttpStatus::EXT_CURL_MULTI, andHttpStatus::LLCOREdefinitions. - Ensure the definitions match the
static constdeclarations inhttpcommon.hto satisfy ODR-use/linker requirements.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These static consts in
HttpStatuswere not actually defined --fails with a link error periodically on Xcode 26.6 and maybe some other toolchains.