Fix LLLeap teardown ordering in macOS integration-test exits#5989
Merged
akleshchev merged 1 commit intoJul 11, 2026
Merged
Conversation
Copilot
AI
changed the title
Fix macOS llleap integration test exit handling
Fix LLLeap teardown ordering in macOS integration-test exits
Jul 11, 2026
Copilot created this pull request from a session on behalf of
akleshchev
July 11, 2026 12:53
View session
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
akleshchev
approved these changes
Jul 11, 2026
e276f54
into
andreyk/boost_process_experiment
5 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The macOS
build (macos-15-xlarge, Release)job was failing inINTEGRATION_TEST_llleapbecauseLLProcesscould publish child-exit state before all ready pipe callbacks had been delivered. That letLLLeaptear itself down while final stdout/stderr data was still pending.Root cause
LLProcess::handleExit()drained at most 10 ready I/O handlers after process exit.LLLeapconsumes child pipe events from those callbacks, so early exit notification could race ahead of final message delivery.Change
poll_one()loop that runs until no ready handlers remain.Effect
Related Issues
Issue Link: relates to GitHub Actions run 29146919898 / job 86532647071
Checklist
Please ensure the following before requesting review:
Additional Notes
The change is intentionally narrow: it only adjusts post-exit pipe draining in
LLProcessand does not alter process-status semantics outside that ordering fix.