docs: deprecate Java Driver 3.x and announce maintenance mode - #919
docs: deprecate Java Driver 3.x and announce maintenance mode#919nikagra wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThe README and changelog now mark Java Driver 3.x as deprecated and in maintenance mode. They direct new development to Driver 4.x and document the critical-fixes policy. README release references, Maven dependency examples, and compatibility information now use version Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
|
@mikliapko When this PR is merged and the information is published with the new driver release, we need to update the generic Drivers page and driver support to indicate that 3.x is deprecated. Sources at https://github.com/scylladb/scylladb-docs-homepage/tree/main/docs |
I suppose it's @nikagra who should have been tagged :) |
True, sorry! |
d261fbd to
97b95eb
Compare
|
Rebased onto current
@annastuchlik — per your comment above, the |
There was a problem hiding this comment.
Note
Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.
🟡 Other comments (2)
README.md-9-9 (1)
9-9: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winCapitalize
GitHubin the prose.Change
github.comtoGitHub. Keep the URL domain lowercase.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` at line 9, Update the README prose around the GitHub reading note to capitalize the brand name as “GitHub,” while preserving the lowercase `github.com` URL domain.Source: Linters/SAST tools
README.md-92-92 (1)
92-92: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick winUpdate the object-mapper dependency documentation.
Line [92] now uses
3.11.5.17, butmanual/object_mapper/README.mdstill documents3.11.5.0. Update that example so users do not receive conflicting release instructions.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` at line 92, Update the object-mapper version example in manual/object_mapper/README.md from 3.11.5.0 to 3.11.5.17 so it matches the version documented in README.md.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Other comments:
In `@README.md`:
- Line 9: Update the README prose around the GitHub reading note to capitalize
the brand name as “GitHub,” while preserving the lowercase `github.com` URL
domain.
- Line 92: Update the object-mapper version example in
manual/object_mapper/README.md from 3.11.5.0 to 3.11.5.17 so it matches the
version documented in README.md.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: QUIET
Plan: Pro Plus
Run ID: 4c3d68fa-3431-4778-99c8-9fd57c817205
📒 Files selected for processing (2)
README.mdchangelog/README.md
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
scylladb/github-automation(auto-detected)scylladb/scylladb(auto-detected)
Mark Java Driver 3.x as deprecated per DRIVER-854: - Add a deprecation notice to README.md, linking to 4.x - Update the Maven dependency version references to 3.11.5.17 The driver enters maintenance mode with only critical bug fixes. Users should migrate to Java Driver 4.x. No changelog entry: changelog/README.md tracks upstream releases only -- no ScyllaDB release has ever been recorded there -- so a fork-lifecycle notice does not belong in it. Fork releases are documented in GitHub Releases. The docs-site half of the announcement is deliberately not here. The Sphinx site is published from the repository's default branch, so both DEPRECATED_VERSIONS and the deprecation banner only take effect on scylla-4.x; they ship as a companion PR. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
97b95eb to
62e0986
Compare
DRIVER-854: Deprecating Java Driver 3.x
Announces that Java Driver 3.x is deprecated and in maintenance mode. Part of DRIVER-483,
tracked as DRIVER-854.
README.mdonly: the deprecation notice at the top with a link to 4.x, and the version referencesupdated from
3.11.5.0to3.11.5.17(the current latest 3.x release).This PR is the announcement. The migration route is #1001 and the docs-site notice is #997, so that
the three review independently.
No changelog entry
An earlier revision added one to
changelog/README.md. Dropped: that file records upstreamreleases only — every commit that has ever touched it is an upstream merge or an upstream
release-prep commit, and no ScyllaDB release (
3.11.5.1…3.11.5.17) appears in it. Fork releasesare documented in GitHub Releases, which is where a reader looks for them. A fork-lifecycle notice
wedged into a list of upstream versions would be the only entry of its kind.
Which PR the site actually sees
scylla-3.xscylla-3.xscylla-4.xThe docs-site half cannot live here.
docs-pages.ymlchecks out${{ github.event.repository.default_branch }}on every publish regardless of which branch waspushed, and
scylla-3.xis not a published doc version at all —/scylla-3.x/returns 404.sphinx-multiversiontakes page content from each version's own ref but
conf.pyandtemplates_pathfrom the publishingbranch, so both
DEPRECATED_VERSIONSand the deprecation banner only take effect there.An earlier revision of this PR also edited
docs/source/conf.pyanddocs/source/_templates/notice.htmlon this branch; both were dropped as no-ops for the publishedsite. To be clear about why: a
_templates/override is a perfectly good mechanism — it is exactlywhat #997 now uses to reach the frozen 3.x branches — it just has no effect from here.
What this means
deprecation notice with a link to the migration guide. (The version picker itself is not marked;
the theme has no mechanism for that.)
Remaining DRIVER-483 tasks (out of scope for this PR)
portals — gates the merge of these three PRs, per the request to coordinate with the other
customer-communication channels first
system.clientsto find deployed 3.x consumers