Remove unused DataStax Astra support - #1034
Conversation
|
Warning Review limit reachedNext included review available in 58 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Team Run ID: 📒 Files selected for processing (4)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (26)
💤 Files with no reviewable changes (20)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR removes DataStax Astra secure-connect-bundle support from public configuration APIs, session construction, cloud topology handling, and SNI SSL handling. It removes cloud proxy arguments and builder methods, the Suggested reviewers: Merge Risk: 🔵 Low · up to This change removes unsupported Astra bundle connectivity and requires affected users to migrate to ordinary endpoint and TLS settings. Deployments that retain legacy bundle configuration may not fail immediately and could connect using unintended settings or fail to connect, so migration handling should receive explicit owner attention. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation The reviewable changes satisfy the main requirements in [ Resolution Provide evidence that Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a0fb0bd to
a6a40b9
Compare
Closes #1026. Part of #1025.
What and why
Remove DataStax Astra secure-connect-bundle parsing, topology/SNI routing, public configuration, examples, and tests. ScyllaDB does not use or test this path, so deleting it reduces unverified production and test code that the team must support.
Scylla client routes/private-endpoint support is preserved.
Validation
mvn -pl core clean test— 3,955 unit tests and 76 Reactive Streams TCK checks passed.mvn -pl core -DskipTests verifymvn -pl examples -DskipTests package-Pfast/missing-sources incompatibility.Dependencies: none. Cherry-picked commits: none.