Skip to content

Remove unused DataStax Astra support - #1034

Open
dkropachev wants to merge 1 commit into
scylla-4.xfrom
cleanup/1026-remove-astra
Open

Remove unused DataStax Astra support#1034
dkropachev wants to merge 1 commit into
scylla-4.xfrom
cleanup/1026-remove-astra

Conversation

@dkropachev

Copy link
Copy Markdown

Closes #1026. Part of #1025.

What and why

Remove DataStax Astra secure-connect-bundle parsing, topology/SNI routing, public configuration, examples, and tests. ScyllaDB does not use or test this path, so deleting it reduces unverified production and test code that the team must support.

Scylla client routes/private-endpoint support is preserved.

Validation

  • mvn -pl core clean test — 3,955 unit tests and 76 Reactive Streams TCK checks passed.
  • mvn -pl core -DskipTests verify
  • mvn -pl examples -DskipTests package
  • Full fast reactor compiled through integration and OSGi modules; its distribution assembly then hit the existing -Pfast/missing-sources incompatibility.

Dependencies: none. Cherry-picked commits: none.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Team

Run ID: b9272de6-4997-42c8-be12-ddcd3f9bb5dd

📥 Commits

Reviewing files that changed from the base of the PR and between a0fb0bd and a6a40b9.

📒 Files selected for processing (4)
  • core/pom.xml
  • examples/src/main/java/com/datastax/oss/driver/examples/mapper/KillrVideoMapperExample.java
  • integration-tests/pom.xml
  • pom.xml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: 9e68619e-27ad-41e4-83fc-4c035bcd4e29

📥 Commits

Reviewing files that changed from the base of the PR and between dc58ee9 and a0fb0bd.

⛔ Files ignored due to path filters (1)
  • core/src/test/resources/config/cloud/creds.zip is excluded by !**/*.zip
📒 Files selected for processing (26)
  • changelog/README.md
  • core/src/main/java/com/datastax/oss/driver/api/core/config/DefaultDriverOption.java
  • core/src/main/java/com/datastax/oss/driver/api/core/config/TypedDriverOption.java
  • core/src/main/java/com/datastax/oss/driver/api/core/session/ProgrammaticArguments.java
  • core/src/main/java/com/datastax/oss/driver/api/core/session/SessionBuilder.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/config/cloud/CloudConfig.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/config/cloud/CloudConfigFactory.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/context/DefaultDriverConfigReporter.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/context/DefaultDriverContext.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/metadata/CloudTopologyMonitor.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/metadata/SniEndPoint.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/ssl/SniSslEngineFactory.java
  • core/src/main/resources/reference.conf
  • core/src/test/java/com/datastax/oss/driver/internal/core/config/cloud/CloudConfigFactoryTest.java
  • core/src/test/java/com/datastax/oss/driver/internal/core/context/ClientRoutesConfigFromFileTest.java
  • core/src/test/java/com/datastax/oss/driver/internal/core/context/DefaultDriverConfigReporterTest.java
  • core/src/test/resources/config/cloud/identity.jks
  • core/src/test/resources/config/cloud/metadata.json
  • core/src/test/resources/config/cloud/trustStore.jks
  • examples/src/main/java/com/datastax/oss/driver/examples/astra/AstraReadCassandraVersion.java
  • examples/src/main/java/com/datastax/oss/driver/examples/mapper/KillrVideoMapperExample.java
  • integration-tests/src/test/java/com/datastax/oss/driver/api/core/cloud/CloudIT.java
  • integration-tests/src/test/java/com/datastax/oss/driver/api/core/cloud/SniProxyRule.java
  • integration-tests/src/test/java/com/datastax/oss/driver/api/core/cloud/SniProxyServer.java
  • manual/core/address_resolution/README.md
  • upgrade_guide/README.md
💤 Files with no reviewable changes (20)
  • core/src/test/resources/config/cloud/metadata.json
  • integration-tests/src/test/java/com/datastax/oss/driver/api/core/cloud/SniProxyRule.java
  • core/src/main/java/com/datastax/oss/driver/api/core/config/DefaultDriverOption.java
  • examples/src/main/java/com/datastax/oss/driver/examples/astra/AstraReadCassandraVersion.java
  • core/src/test/java/com/datastax/oss/driver/internal/core/context/DefaultDriverConfigReporterTest.java
  • core/src/main/resources/reference.conf
  • core/src/test/java/com/datastax/oss/driver/internal/core/context/ClientRoutesConfigFromFileTest.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/context/DefaultDriverConfigReporter.java
  • core/src/test/java/com/datastax/oss/driver/internal/core/config/cloud/CloudConfigFactoryTest.java
  • integration-tests/src/test/java/com/datastax/oss/driver/api/core/cloud/SniProxyServer.java
  • integration-tests/src/test/java/com/datastax/oss/driver/api/core/cloud/CloudIT.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/config/cloud/CloudConfigFactory.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/ssl/SniSslEngineFactory.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/config/cloud/CloudConfig.java
  • core/src/main/java/com/datastax/oss/driver/api/core/session/ProgrammaticArguments.java
  • core/src/main/java/com/datastax/oss/driver/api/core/config/TypedDriverOption.java
  • core/src/main/java/com/datastax/oss/driver/api/core/session/SessionBuilder.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/metadata/CloudTopologyMonitor.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/metadata/SniEndPoint.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/context/DefaultDriverContext.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR removes DataStax Astra secure-connect-bundle support from public configuration APIs, session construction, cloud topology handling, and SNI SSL handling. It removes cloud proxy arguments and builder methods, the basic.cloud configuration block, and Astra-related runtime paths. Client-routes documentation no longer lists secure-connect bundles as a conflicting configuration. An Astra example is deleted, and example text now references ScyllaDB.

Suggested reviewers: nikagra

Merge Risk: 🔵 Low · up to a0fb0

This change removes unsupported Astra bundle connectivity and requires affected users to migrate to ordinary endpoint and TLS settings. Deployments that retain legacy bundle configuration may not fail immediately and could connect using unintended settings or fail to connect, so migration handling should receive explicit owner attention.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check ❓ Inconclusive The reviewable changes satisfy the main requirements in [#1026], including removal of Astra parsing, APIs, runtime support, examples, tests, and documentation, while preserving client-routes support. … Provide evidence that core/src/test/resources/config/cloud/creds.zip and all native-image/build entries are removed, and confirm that no withCloudSecureConnectBundle or Astra-specific runtime references remain outside the reviewed files…
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the primary change: removal of unused DataStax Astra support.
Description check ✅ Passed The description directly explains the Astra support removal and the preservation of Scylla client-routes and private-endpoint support.
Out of Scope Changes check ✅ Passed The changes are related to [#1026]. They remove Astra implementation, APIs, examples, tests, fixtures, and documentation without introducing unrelated functionality.
Full details: Linked Issues check

Explanation

The reviewable changes satisfy the main requirements in [#1026], including removal of Astra parsing, APIs, runtime support, examples, tests, and documentation, while preserving client-routes support. The Astra fixture core/src/test/resources/config/cloud/creds.zip is excluded by !**/*.zip, so complete fixture removal and repository-wide absence of Astra references cannot be verified.

Resolution

Provide evidence that core/src/test/resources/config/cloud/creds.zip and all native-image/build entries are removed, and confirm that no withCloudSecureConnectBundle or Astra-specific runtime references remain outside the reviewed files.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 unsupported.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dkropachev
dkropachev force-pushed the cleanup/1026-remove-astra branch from a0fb0bd to a6a40b9 Compare September 1, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove DataStax Astra secure-connect-bundle support

1 participant