Skip to content

fix: release stream ids on request setup failure - #1008

Draft
dkropachev wants to merge 1 commit into
scylladb:scylla-4.xfrom
dkropachev:dk/1002-release-acquired-stream-id
Draft

fix: release stream ids on request setup failure#1008
dkropachev wants to merge 1 commit into
scylladb:scylla-4.xfrom
dkropachev:dk/1002-release-acquired-stream-id

Conversation

@dkropachev

Copy link
Copy Markdown

Summary

  • release a concrete stream ID when request frame creation fails
  • release the ID when callback registration rejects the request
  • preserve ownership after successful in-flight registration
  • cover both failure windows with stateful stream-ID regression tests

Fixes #1002.

Tests

  • JAVA_HOME=.../11.0.29-tem mvn -pl core -am -DskipITs -Dtest=InFlightHandlerTest -Dsurefire.failIfNoSpecifiedTests=false test

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: 7085c3a4-addc-4d68-b0db-4f1eb8bf1d28

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4.x: Stream ID can leak when InFlightHandler fails after acquisition

1 participant