minor: fix join page icons - #284
Merged
Merged
Conversation
The icon class was concatenated onto card-title with no separator, so every card rendered class="card-titlebi-github" and neither class applied. That is why the page shows no icons, and why the X card looks empty: its label comes entirely from .i-xcom::before, with title deliberately blank. Adding a space does not survive CI - prettier-plugin-go-template collapses whitespace between template actions in an attribute, which is what reverted #282 and left that merge empty. The icon class now sits on its own span, so there is no combined attribute to format.
✅ Deploy Preview for jade-cajeta-1bcca0 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Icon class was concatenated onto card-title with no separator so every card rendered class="card-titlebi-github" and neither class applied. That is why the page shows no icons and why the X card looks empty: its label comes entirely from .i-xcom::before with a deliberately blank title.
Adding a space does not survive CI. prettier-plugin-go-template collapses whitespace between template actions in an attribute, which is what reverted #282 and left that merge empty. The icon class now sits on its own span so there is no combined attribute to format.