Skip to content

fix: give pertpy its logo blue as accent - #72

Merged
Zethson merged 3 commits into
mainfrom
pertpy-accent
Oct 22, 2026
Merged

Zethson merged 3 commits into
mainfrom
pertpy-accent

Conversation

@Zethson

@Zethson Zethson commented Oct 22, 2026

Copy link
Copy Markdown
Member

Maps pertpy to the new --pertpy-blue from scverse/scverse.github.io#364 instead of scirpy's pink and regenerates _accents.json. Merge after the website PR, since the sync script reads the website.

The website now defines --pertpy-blue (scverse/scverse.github.io#364), so pertpy no longer borrows scirpy's pink.
_accents.json was regenerated with scripts/sync_brand_tokens.py against that branch; no other token changed.
@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 scverse-doc | 🛠️ Build #35319492 | 📁 Comparing 4d9c6ef against latest (1130827)

  🔍 Preview build  

1 file changed
± changelog.html

@Zethson
Zethson merged commit c93914a into main Oct 22, 2026
7 of 8 checks passed
@Zethson
Zethson deleted the pertpy-accent branch October 22, 2026 08:26
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (1130827) to head (db439c7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #72   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          650       650           
=========================================
  Hits           650       650           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Zethson added a commit to scverse/pertpy that referenced this pull request Oct 23, 2026
* Take the docs' accents from the scverse-doc registry and colour the sidebar captions red

scverse-doc's registry now carries pertpy's logo blue (scverse/scverse-doc#72), so the hard-coded accent is redundant, and secondary_accent = True takes pertpy's logo red for the sidebar captions (scverse/scverse-doc#73).
Both need the scverse-doc release after 0.2.4.

* Add changelog entry for #1182

* Require scverse-doc 0.3.0 for the secondary_accent theme option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant