chore: remove external tests and deprecate sc.external - #3645
Draft
flying-sheep wants to merge 6 commits into
Draft
chore: remove external tests and deprecate sc.external#3645flying-sheep wants to merge 6 commits into
flying-sheep wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3645 +/- ##
==========================================
+ Coverage 80.01% 81.32% +1.31%
==========================================
Files 132 132
Lines 13397 13036 -361
==========================================
- Hits 10719 10602 -117
+ Misses 2678 2434 -244
Flags with carried forward coverage won't be shown. Click here to find out more.
|
flying-sheep
changed the title
Zethson
reviewed
Aug 14, 2026
Zethson
left a comment
Zethson
left a comment
Member
There was a problem hiding this comment.
Sorry, I don't know more here than you do.
| @deprecated( | ||
| Deprecation( | ||
| "1.13.0", | ||
| # TODO: better suggestion? |
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m not sure I’m happy with the recommendations, e.g. are the named ones really replacements for mnnpy?
Docs currently fail since we haven’t moved the functions we want to move yet
sc.external#4295