Repository navigation
Release plan to v0.5.0 and sensitive licence changes - #339
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release plan
CONTRIBUTING.md. Every known difference is listed inDIVERGENCE.md. Non-STAR additions sit behind their own flag or cargo feature and are off by default. Every open PR has been dealt with.Until v0.5.0 the rule is: port STAR as written, and anything that isn't STAR is opt-in.
Code under a sensitive licence needs discussion before any work starts
rustar-aligner is MIT-licensed and published. Code that is ported from, adapted from, or written
while reading another project's source carries that project's licence with it. A permissive
licence (MIT, BSD, Apache 2.0) is fine with a notice in
LICENSES/. Anything else is asensitive licence, and a contribution that touches one will most likely not be accepted
unless the way it was developed has been discussed and agreed with the maintainers first. This
is a legal question, not a code-quality one, so a good implementation does not change the answer.
A licence is sensitive if it:
non-commercial, or tied to a vendor's product;
If your work reproduces the behaviour of a tool under a sensitive licence:
develop it (for example from public documentation, published papers, or observed inputs and
outputs). A maintainer will apply the
sensitive licenselabel and the discussionhappens there.
for you. A rewrite done by someone (or something) that has read the source is not a clean
room, and deleting a ported module and rewriting it in the same branch does not remove the
derivation. Git history keeps the ported commits even after a squash.
source under a sensitive licence was consulted.
PRs found to contain code derived from source under a sensitive licence are labelled
sensitive licenseand are not merged while the question is open. If the derivation isconfirmed, the PR is closed. Its history cannot be cleaned up after the fact.