Conversation
3 tasks
There was a problem hiding this comment.
Pull request overview
This PR adjusts how the base-layer ZKVM transcript is constructed for per-chip proving/verifying, aligning native prover/verifier behavior with the recursion verifier by moving chip metadata observations into per-chip “fork” transcripts (instead of the main transcript) and making the fork transcript initialization explicit.
Changes:
- Remove
(circuit_idx, num_instances)observation from the main transcript and instead bind challenges + fork id + metadata into each per-chip transcript. - Update chip scheduling so transcript “forking” is a plain clone, with task-specific transcript appends done inside the task closure.
- Update recursion verifier to build per-chip challengers independently (labeled
fork) and observe the same challenges/metadata order.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ceno_zkvm/src/scheme/verifier.rs | Switch per-chip transcript initialization to BasicTranscript("fork") and move challenge/metadata observations into chip transcripts. |
| ceno_zkvm/src/scheme/scheduler.rs | Remove implicit task_id appends during transcript cloning; closures now bind task-specific transcript state. |
| ceno_zkvm/src/scheme/prover.rs | Stop writing chip metadata into the main transcript; bind challenges/metadata in per-task transcripts and use a dedicated fork transcript template. |
| ceno_recursion/src/zkvm_verifier/verifier.rs | Rework per-chip challenger “forking” to independently initialize and observe alpha/beta + fork id + metadata in verifier order. |
| ceno_recursion/src/transcript/mod.rs | Remove no-longer-used challenger cloning helpers. |
Comment on lines
+177
to
+179
| // Extract chip metadata before consuming witnesses. | ||
| // We reuse this for both transcript appends and task construction. | ||
| let name_and_instances = witnesses.get_witnesses_name_instance(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.