Repository navigation
P3: Store All Teams at War as a mission flag - #8031
Open
dustinspace217 wants to merge 1 commit into
Open
dustinspace217 wants to merge 1 commit into
dustinspace217 wants to merge 1 commit into
Conversation
All Teams at War lived in a global variable set by the +All Teams Attack line, while qtFRED's mission specs list ticked the All_attack mission flag, which nothing read, so ticking it there never reached the saved mission or the game. The flag is now the only place the setting is kept, as with +Red Alert: and +Scramble:. The +All Teams Attack line sets it, the game and the save code read it, and both editors edit it. A mission saved by qtFRED with the box ticked has the flag but no line, and now starts with all teams at war, as its designer asked. A mission with only the line gains the flag in +Flags the next time it is saved; the line is still written, so older builds read it as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
All Teams at War is now kept as a mission flag, like Red Alert and Scramble, instead of a global variable. The
+All Teams Attackline sets the flag, the game and the save code read it, and FRED and qtFRED edit it. The global is gone.Why?
This was asked for in the review of #8028. The flag already existed, and qtFRED's mission specs list ticked it, but nothing read it. Ticking All Teams at War in qtFRED never reached the saved mission or the game.
How?
+All Teams Attackline setsMission::Mission_Flags::All_attack. Its separate reset is gone, since the mission reset already clears the flags.Testing?
team:attacks()for every pair of teams:bta2_m1_03, which uses the line: at war on both builds.Anything Else?
+Flags:the next time it is saved. The line is still written, so older builds read it as before.