Add Scoop and WinGet support for Windows#484
Conversation
2c04b96 to
05a28e4
Compare
|
Hey @mathieu-benoit, |
|
Hi @mathieu-benoit, |
| commit_msg_template: "Scoop update for {{ .ProjectName }} version {{ .Tag }}" | ||
| commit_author: | ||
| name: rachfop | ||
| email: prachford@icloud.com |
There was a problem hiding this comment.
Noticed this uses a personal identity (name/email) rather than a bot account. I see brews already does this, so it's an existing pattern, not something this PR introduced, just flagging that copying it into two more places might be worth fixing now rather than later. Totally fine to leave as-is if that's intentional for the project, just wanted to raise it.
| license_url: "https://github.com/score-spec/score-compose/blob/main/LICENSE" | ||
| publisher_url: "https://score.dev" | ||
| publisher_support_url: "https://github.com/score-spec/score-compose/issues" | ||
| package_identifier: score-spec.score-compose |
There was a problem hiding this comment.
Quick question, do you know if WinGet's validation bot requires PascalCase for the publisher/package name (like ScoreSpec.ScoreCompose)? I've seen that convention in some other winget-pkgs manifests but I'm honestly not 100% sure it's enforced vs just a convention. Might be worth checking microsoft/winget-pkgs for similar CLI tools before moving ahead, since if the bot rejects it that'd block the whole release step.
| email: prachford@icloud.com | ||
| repository: | ||
| owner: score-spec | ||
| name: winget-pkgs |
There was a problem hiding this comment.
This assumes score-spec/winget-pkgs already exists as a fork of microsoft/winget-pkgs. Does it? If it needs to be created first, might be worth a short comment right here in the yaml so future maintainers aren't confused about why it's pointing at a repo under score-spec.
| **[Scoop](https://scoop.sh/) (recommended):** | ||
|
|
||
| ```powershell | ||
| scoop bucket add score-spec https://github.com/score-spec/scoop-bucket |
There was a problem hiding this comment.
This points at score-spec/scoop-bucket, which doesn't exist yet as far as I can tell. If that's right, anyone following these instructions today would hit a 404. Might be worth holding this README section until the bucket exists and has a manifest in it, or marking it "coming soon" for now, or any other solution if we have.
| **[WinGet](https://learn.microsoft.com/en-us/windows/package-manager/winget/) (Windows 10/11 built-in):** | ||
|
|
||
| ```powershell | ||
| winget install score-spec.score-compose |
There was a problem hiding this comment.
Same question here, winget install score-spec.score-compose will only work once a manifest has actually been merged into microsoft/winget-pkgs. Worth gating this doc update on that happening first, otherwise it's a broken instruction for anyone reading the README before the first release goes through.
There was a problem hiding this comment.
@mathieu-benoit (tagging you in case this is useful, please correct me if I've got anything wrong here, still learning the podman/release tooling side of things and just trying to help where I can)
Really nice to see Windows support getting added, this closes a real gap. I tested this locally with goreleaser check and a snapshot build, and left a few inline notes, mostly around two things that would break for users as-is (the Scoop bucket and WinGet manifest repos don't exist yet, so the README instructions would fail immediately), plus a couple of smaller consistency/config suggestions. Nothing here should be hard to address, happy to help test again once updated.
Signed-off-by: Abhishek <abhishekup082@gmail.com>
2 participants
Add Scoop and WinGet support for Windows (#147)
Description
This adds Windows package manager support to
score-composeso that Windows users can install the CLI without manually downloading and extracting a zip file.Two package managers are now supported via GoReleaser automation:
score-spec/scoop-bucketon every release using the existingTAP_GITHUB_TOKENsecret (same token already used for Homebrew, so no new secrets are needed).microsoft/winget-pkgsviascore-spec/winget-pkgsfork on every release.The
README.mdinstallation section has also been updated to document all three Windows install methods: Scoop, WinGet, and manual download.What does this PR do?
Closes #147
Windows users currently have no package manager option for
score-composethey have to go to the Releases page, download a zip, extract it, and manually add the binary to their PATH. This PR wires up GoReleaser to handle Scoop and WinGet publishing automatically on every release, bringing the Windows experience on par with macOS (Homebrew).Types of changes
Checklist: