Conversation
|
Hi! Your PR was missing some labels 🔖 so I added them: CI |
MridulS
commented
May 21, 2026
Comment on lines
+65
to
+70
| # Query the labels currently on the PR rather than reading them from | ||
| # the event payload. The payload is a snapshot taken when the event | ||
| # was created, so labels the author adds right after opening the PR | ||
| # (a common case) would be missing from it and wrongly reported as | ||
| # newly added by the bot. See issue #584. | ||
| EXISTING_LABELS="$(gh pr view ${PR_NUM} --json labels --jq '.labels[].name')"; |
Member
Author
There was a problem hiding this comment.
I'm not a 100% sure if this change is actually a good idea. If the tag is added at the moment the PR is created it should be in the payload already so we don't need to use the gh cli.
Member
There was a problem hiding this comment.
We'll still have the same problem anyway if human is faster than this line to be executed, no?
Member
There was a problem hiding this comment.
Or we should just remove the commenting part. It's cute but makes things unnecessarily complicated I think....
Member
Author
There was a problem hiding this comment.
Yeah maybe just remove the autocommenting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #584