ENH: Prefer excluding upper bound in streamline length filtering - #1344
Open
jhlegarreta wants to merge 1 commit into
Open
ENH: Prefer excluding upper bound in streamline length filtering#1344jhlegarreta wants to merge 1 commit into
jhlegarreta wants to merge 1 commit into
Conversation
Change streamline length filtering to use a half-open interval, including streamlines at the minimum length threshold while excluding those exactly matching the maximum length threshold. Using a half-open interval simplifies length binning by allowing natural bin definitions (e.g., [80, 90), [90, 100), etc.), avoiding arbitrary floating-point thresholds (e.g. [80-89.99], [90-99.99] or [80.01-90], [90.01-100], etc.) and preventing duplicate assignments at bin boundaries. Also, this allows the philosophy to be consistent with major Python packages like NumPy, etc. when dealing with intervals.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1344 +/- ##
=======================================
Coverage 72.59% 72.59%
=======================================
Files 301 301
Lines 26283 26283
Branches 3700 3700
=======================================
+ Hits 19080 19081 +1
+ Misses 5651 5650 -1
Partials 1552 1552
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick description
Change streamline length filtering to use a half-open interval, including streamlines at the minimum length threshold while excluding those exactly matching the maximum length threshold.
Using a half-open interval simplifies length binning by allowing natural bin definitions (e.g., [80, 90), [90, 100), etc.), avoiding arbitrary floating-point thresholds (e.g. [80-89.99], [90-99.99] or [80.01-90], [90.01-100], etc.) and preventing duplicate assignments at bin boundaries.
Also, this allows the philosophy to be consistent with major Python packages like NumPy, etc. when dealing with intervals.
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
N/A
Checklist