fix: force BUILD_TESTING to inherit RUN_NINJA_TEST value - #340
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses #330 by preventing Ninja’s upstream CMake from enabling its test infrastructure (and thereby fetching GoogleTest) when RUN_NINJA_TEST is disabled during packaging/install builds.
Changes:
- Propagate
RUN_NINJA_TESTintoBUILD_TESTINGbefore adding theninja-upstreamsubdirectory. - Increase verbosity for the SDist installation step in the GitHub Actions workflow to aid debugging build/install failures.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CMakeLists.txt | Sets BUILD_TESTING based on RUN_NINJA_TEST prior to configuring ninja-upstream, aiming to prevent test deps (e.g., GTest) from being fetched when tests are off. |
| .github/workflows/build.yml | Adds -v to the SDist install command to provide more detailed logs in CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
henryiii
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #330