Add DisplayMap to OpticalStimulationConfig - #83
Merged
Conversation
namthor9
force-pushed
the
maxr/optical-stim-display-map
branch
from
June 26, 2026 23:37
d84c9fb to
03532bb
Compare
Adds a DisplayMap message (row_map/col_map) and an optional display_map field to OpticalStimulationConfig, for runtime-configurable optical-stim pin mapping. Index = logical row/col, value = physical chip pin; map lengths define the display dimensions.
calvinleng-science
force-pushed
the
maxr/optical-stim-display-map
branch
from
August 4, 2026 23:41
03532bb to
d392981
Compare
calvinleng-science
approved these changes
Aug 4, 2026
calvinleng-science
left a comment
calvinleng-science
left a comment
Contributor
There was a problem hiding this comment.
bumped the version and added a comment explaining the expectation for implementers of DisplayMap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
DisplayMapmessage (row_map/col_map) and an optionaldisplay_mapfield (7) toOpticalStimulationConfig.Display ICs may have arbitrary mappings between display pixels and driver outputs. Previously, this mapping was hard-coded in peripheral implementations, which did not allow for easy configurability for different probe designs.