Skip to content

馃И test(nmea): add unit tests for znt_logger_opts - #41

Merged
schwehr merged 1 commit into
mainfrom
test/nmea-znt-logger-opts-13483990023100024360
Sep 23, 2026
Merged

schwehr merged 1 commit into
mainfrom
test/nmea-znt-logger-opts-13483990023100024360

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

Add unit tests for znt_logger_opts and ZntLogger(verbose=True) in tests/test_nmea/test_znt.py to cover option parsing defaults, custom flags, and verbose output logging.


PR created automatically by Jules for task 13483990023100024360 started by @schwehr

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

馃憢 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 馃憖 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

馃煝 Approval recommended

No unresolved review comments; the focused test coverage is complete.

Review effort: Lite
Findings: None

What changed in this PR

Adds unit tests for znt_logger_opts parsing and verbose ZntLogger output.

Changes:

  • Tests default and custom logger options.
  • Tests verbose NMEA logging.
File Description
tests/鈥媡est_nmea/鈥媡est_znt.py Adds option parsing and verbose logger tests.

馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@schwehr
schwehr merged commit e9a30c6 into main Sep 23, 2026
3 checks passed
@schwehr
schwehr deleted the test/nmea-znt-logger-opts-13483990023100024360 branch September 23, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants