🧪 test(nmea): add test file and comprehensive tests for rmc.py - #38
Conversation
Extracts duplicate rmc tests from `test_rmc_zda_znt.py` and creates a dedicated `test_rmc.py` file with more comprehensive tests for regex extraction and boundary conditions on coordinate processing. Renames old test file to `test_zda_znt.py`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Missing test file for
src/nmea/rmc.pyaddressed by creating a dedicatedtests/test_nmea/test_rmc.py.📊 Coverage: Added comprehensive tests for NMEA RMC sentence regex extraction (all match groups) and the
lonlatprocessing method, covering north/east, south/west, exact zeros, and edge cases where zero-padding strings lead to empty conditions.✨ Result: Test coverage significantly improved for the
rmc.pyfile, establishing a safe baseline for this module. Also cleaned uptest_rmc_zda_znt.pyintotest_zda_znt.py.PR created automatically by Jules for task 4834563210980612454 started by @schwehr