🧪 Add comprehensive tests for NMEA GGA and ZDA decoders - #35
Conversation
- Added `tests/test_nmea/test_gga.py` file. - Included robust tests for `zdaDecode`, `ggaDecode`, `zdaEpochSeconds`, and `zdaDict2TIMESTAMP`. - Verified latitude/longitude calculations and exception handling. - Corrected strict length assertion (from 78 to 82) in `src/nmea/gga.py` to allow valid GGA strings with differentials. - Formatted with `ruff`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: Added a missing test suite for
src/nmea/gga.pyand fixed an overly strict string length assertion inggaDecodevalidation.📊 Coverage:
zdaDecode(Valid / Invalid formats)zdaEpochSeconds(Timestamp generation)zdaDict2TIMESTAMP(Formatting)ggaDecode(Valid formats across different hemispheres, age of differentials, Invalid formats)✨ Result: Enhanced test coverage for the NMEA decoding module ensuring decoding accuracy for critical coordinates and timestamp data. In doing so, we spotted an edge-case bug with long GGA messages (NMEA 0183 spec allows up to 82 characters), which was promptly fixed.
PR created automatically by Jules for task 9172776886316595645 started by @schwehr