Skip to content

🧪 Add tests for nmea_error.py - #32

Merged
schwehr merged 1 commit into
mainfrom
add-nmea-error-tests-16436397272205060426
Sep 19, 2026
Merged

schwehr merged 1 commit into
mainfrom
add-nmea-error-tests-16436397272205060426

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

🎯 What: Created a test file test_nmea_error.py to establish a testing baseline for the exception classes in src/nmea/nmea_error.py since it lacked test coverage.
📊 Coverage: Covered all exception classes in the module: NmeaError and NmeaChecksumError. Verified class inheritances, their ability to be raised properly, and their representation strings.
Result: Improved test coverage for nmea_error.py to 100%. Ensures a basic baseline for current and future exceptions in the NMEA parsing functionality.


PR created automatically by Jules for task 16436397272205060426 started by @schwehr

- Created tests/test_nmea/test_nmea_error.py.
- Verified inheritances of NmeaError and NmeaChecksumError.
- Verified exceptions can be raised and caught.
- Achieved 100% coverage on src/nmea/nmea_error.py.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@schwehr schwehr left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This are kind of silly, but why not.

@schwehr
schwehr merged commit 491d5e2 into main Sep 19, 2026
2 checks passed
@schwehr
schwehr deleted the add-nmea-error-tests-16436397272205060426 branch September 19, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant