build(deps): bump dependabot dependencies - #1157
Closed
JeanMarcMilletScality wants to merge 1 commit into
Closed
Conversation
Ships the pending dependabot bumps in a single PR, since the individual dependabot PRs cannot merge (the claude-review check fails on dependabot PRs because repository secrets are not exposed to that context). Direct: - react-router 7.13.0 -> 7.15.1 - react-router-dom 7.13.0 -> 7.15.1 (kept in lockstep with react-router to avoid a duplicate/mismatched react-router copy and split Router context) Transitive / dev (resolved to latest compatible, >= dependabot proposals): - @babel/core 7.28.6 -> 7.29.7 (security/bug fixes; dev only) - esbuild 0.25.12 -> 0.28.1 (security: dev-server path traversal, Deno integrity) - markdown-it 14.1.1 -> 14.3.0 (security/perf; CommonMark fixes) - linkify-it 5.0.0 -> 5.0.2 (security: fuzzy-link ReDoS) - ws 8.20.1 -> 8.21.1 (security: remote memory-exhaustion DoS) All 513 tests pass and tsc build succeeds. Vulnerability count 5 -> 1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
JBWatenbergScality
approved these changes
Jul 17, 2026
Contributor
Author
|
/approve |
Contributor
Author
|
/status |
1 similar comment
Contributor
Author
|
/status |
Contributor
Author
|
Superseded by #1176 — same commit, re-opened from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Bumps six dependencies (react-router, react-router-dom, @babel/core, esbuild, markdown-it, linkify-it, ws) in one PR — the changes dependabot proposed across separate PRs, consolidated so they can actually land.
Context
Dependabot opened these as individual PRs, but none can merge: the
claude-reviewcheck fails on every dependabot PR because repository secrets aren't exposed to the dependabot Actions context. This PR ships the same bumps from a normal branch instead. (The CI gate itself is tracked for a separate fix.)Changes
react-routerreact-router-dom@babel/coreesbuildmarkdown-itlinkify-itwsesbuildandwsmatch dependabot's proposed versions exactly; the other transitive/dev deps resolved one patch/minor newer vianpm update(all within existing ranges, no breaking changes — markdown-it 14.3.0 is a single CommonMark hard-line-break fix).Approach
Why react-router-dom moves with react-router. Dependabot's PR bumped only
react-router. Butreact-router-dom@7.13.0hard-pinsreact-router@7.13.0, so bumping react-router alone leaves a second, nested copy of react-router in the tree — two separate Router contexts, which breaksuseNavigate/useLocationfor consumers whose provider comes from the other copy.Before — react-router bumped alone (dependabot #1131):
After — pair bumped together (this PR):
Verified the built lockfile contains exactly one
node_modules/react-routerentry.Review focus
package.json›react-router+react-router-dom— both pinned to exactly7.15.1; confirm they stay aligned (this is the shipped runtime dep). core-ui's own code uses onlyuseLocation/useNavigate, stable across 7.x.package-lock.json— changes are scoped to the six deps plus their@babel/*/@esbuild/*sub-packages; no unrelated churn.How to test
npm auditdrops from 5 vulnerabilities to 1.References
Supersedes the individual dependabot PRs (can be closed once this merges):
🤖 Generated with Claude Code