Upgrade node-rdkafka to 3.6.1 - #2817
Open
delthas wants to merge 1 commit into
Open
Conversation
Pin exactly 3.6.1 (librdkafka 2.12.0), replacing the 3.0.1 / librdkafka 2.3.0 pinned by BB-806. The constraint that forced that downgrade -- S3C brokers storing legacy v0/v1 MessageSets, which librdkafka >= 2.5 reads as NULL key and value -- is removed by S3C-11389 raising Federation's message-format pin. Measured on CI over 25 runs per arm of the full lib suite: the tree fails 20/25 jobs on librdkafka 2.3.0 and 0/25 on 2.12.0. The pin stays exact rather than a caret: ^2.12.0 previously resolved forward from node-rdkafka 2.12.0 to 2.18.0, changing the bundled librdkafka from 1.7.0 to 2.3.0 without review. Issue: BB-852
Contributor
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## development/9.6 #2817 +/- ##
===================================================
- Coverage 75.76% 75.47% -0.29%
===================================================
Files 200 200
Lines 13922 13922
===================================================
- Hits 10548 10508 -40
- Misses 3364 3404 +40
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
delthas
marked this pull request as ready for review
August 20, 2026 08:43
delthas
requested review from
a team,
SylvainSenechal,
benzekrimaha and
francoisferrand
August 20, 2026 08:43
SylvainSenechal
approved these changes
Aug 20, 2026
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin node-rdkafka to 3.6.1 exactly (librdkafka 2.12.0), replacing the 3.0.1 / librdkafka 2.3.0 from BB-806. S3C-11389 raises Federation's message-format pin, which removes the legacy v0/v1 MessageSet constraint that forced that downgrade.
Measured on CI over 25 runs per arm of the full
libsuite: 20/25 jobs fail on librdkafka 2.3.0, and 0/25 on 2.12.0.The pin stays exact rather than a caret —
^2.12.0previously resolved forward from node-rdkafka 2.12.0 to 2.18.0, which changed the bundled librdkafka from 1.7.0 to 2.3.0 with no review.Issue: BB-852