fix codespace yarn setup prompt#2448
Conversation
Hello sylvainsenechal,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
| }, | ||
| // Use 'postCreateCommand' to run commands after the container is created. | ||
| "postCreateCommand": ".devcontainer/setup.sh" | ||
| "postCreateCommand": "sudo corepack enable && corepack prepare yarn@1.22.22 --activate && .devcontainer/setup.sh" |
There was a problem hiding this comment.
we don't actually use corepack:
- should the change not be to disable corepack ?
- can't it be done during the build (in Dockerfile), instead of doing it on startup?
There was a problem hiding this comment.
had similar issue on my laptop, c.f. https://scality.slack.com/archives/C0A1GUKGLNS/p1773765068189439
There was a problem hiding this comment.
Let me see, looking on some threads i saw some people using an env var to disable it
6885656 to
1ed6ddc
Compare
| "containerEnv": { | ||
| "ZENKO_MONGODB_DATABASE": "zenko-database" | ||
| "ZENKO_MONGODB_DATABASE": "zenko-database", | ||
| "COREPACK_ENABLE_DOWNLOAD_PROMPT": "0" |
There was a problem hiding this comment.
does this disable "corepack" (i.e. same as corepack disable) ? or does it disable the prompt?
There was a problem hiding this comment.
it doesn't disable the prompt, and we aren't using corepack currently so we can disable it. I guess both solution are ok though
1ed6ddc to
eb0fc7d
Compare
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
This pull request did not target the following hotfix branch(es) so they
Please check the status of the associated issue ZENKO-5301. Goodbye sylvainsenechal. The following options are set: approve |
Issue: ZENKO-5301
Issue probably introduced when I changed the resources setup from python to typescript.
In codespace, after the cluster is deployed, we (the codespace, it's not the developer doing this manually 🧐 ) need to run the typescript resources setup script, but it's blocked with :

This shouldn't require manual intervention, and anyways, this screenshot is from the codespace creation log, it's not an interactive shell, we can't 'Y' that thing