Skip to content

fix codespace yarn setup prompt#2448

Merged
bert-e merged 1 commit into
development/2.15from
improvement/ZENKO-5301
Jun 26, 2026
Merged

fix codespace yarn setup prompt#2448
bert-e merged 1 commit into
development/2.15from
improvement/ZENKO-5301

Conversation

@SylvainSenechal

@SylvainSenechal SylvainSenechal commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Issue: ZENKO-5301

Issue probably introduced when I changed the resources setup from python to typescript.

In codespace, after the cluster is deployed, we (the codespace, it's not the developer doing this manually 🧐 ) need to run the typescript resources setup script, but it's blocked with :
image

This shouldn't require manual intervention, and anyways, this screenshot is from the codespace creation log, it's not an interactive shell, we can't 'Y' that thing

@bert-e

bert-e commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue ZENKO-5301 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.15.2

Please check the Fix Version/s of ZENKO-5301, or the target
branch of this pull request.

@SylvainSenechal SylvainSenechal requested review from a team, benzekrimaha and delthas June 23, 2026 15:18
Comment thread .devcontainer/devcontainer.json Outdated
},
// Use 'postCreateCommand' to run commands after the container is created.
"postCreateCommand": ".devcontainer/setup.sh"
"postCreateCommand": "sudo corepack enable && corepack prepare yarn@1.22.22 --activate && .devcontainer/setup.sh"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't actually use corepack:

  • should the change not be to disable corepack ?
  • can't it be done during the build (in Dockerfile), instead of doing it on startup?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me see, looking on some threads i saw some people using an env var to disable it

Comment thread .devcontainer/devcontainer.json Outdated
"containerEnv": {
"ZENKO_MONGODB_DATABASE": "zenko-database"
"ZENKO_MONGODB_DATABASE": "zenko-database",
"COREPACK_ENABLE_DOWNLOAD_PROMPT": "0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this disable "corepack" (i.e. same as corepack disable) ? or does it disable the prompt?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't disable the prompt, and we aren't using corepack currently so we can disable it. I guess both solution are ok though

@SylvainSenechal

Copy link
Copy Markdown
Contributor Author

/approve

@scality scality deleted a comment from bert-e Jun 26, 2026
@bert-e

bert-e commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.15

The following branches have NOT changed:

  • development/2.10
  • development/2.11
  • development/2.12
  • development/2.13
  • development/2.14
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

This pull request did not target the following hotfix branch(es) so they
were left untouched:

  • hotfix/2.13.5

Please check the status of the associated issue ZENKO-5301.

Goodbye sylvainsenechal.

The following options are set: approve

@bert-e bert-e merged commit eb0fc7d into development/2.15 Jun 26, 2026
22 checks passed
@bert-e bert-e deleted the improvement/ZENKO-5301 branch June 26, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants