ARSN-626: bump sproxydclient to 8.2.2 - #2687
Conversation
Hello tcarmet,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/8.4 #2687 +/- ##
================================================
Coverage 74.42% 74.42%
================================================
Files 229 229
Lines 18546 18546
Branches 3809 3834 +25
================================================
Hits 13802 13802
Misses 4739 4739
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sproxydclient now treats any 2xx response from sproxyd as a success instead of whitelisting 200 and 206. sproxyd answers DELETE and POST .batch_delete with 204 (no content), which the previous whitelist turned into an error, and DataWrapper then retried three times before surfacing an InternalError. Also bumps the package version to 8.4.24. Issue: ARSN-626
a8390e2 to
8c136af
Compare
|
/create_integration_branches |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: git fetch
git checkout -B w/8.5/bugfix/ARSN-626-bump-sproxydclient origin/development/8.5
git merge origin/bugfix/ARSN-626-bump-sproxydclient
# <intense conflict resolution>
git commit
git push -u origin w/8.5/bugfix/ARSN-626-bump-sproxydclientThe following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
|
/status |
Status
The following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
This pull request does not target the following hotfix branch(es) so they
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve, create_integration_branches |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-626. Goodbye tcarmet. |
4 participants
sproxyd now answers DELETE and batch-delete requests with 204 No Content. The sproxyd client Arsenal depends on only accepted 200 and 206 as success, so those replies were treated as failures, retried, and eventually surfaced to callers as internal errors. This picks up the client version that accepts any 2xx, so deletes succeed again.