tests(all): bump go-vcr to v3.2.0#4909
Draft
Mia-Cross wants to merge 11 commits into
Draft
Conversation
github-actions
Bot
added
registry
Mia-Cross
force-pushed
the
tests_bump_go_vcr_to_v3
branch
4 times, most recently
from
July 24, 2025 13:08
61681b3 to
d5a9323
Compare
Mia-Cross
force-pushed
the
tests_bump_go_vcr_to_v3
branch
from
July 30, 2025 15:59
d5a9323 to
62cd17c
Compare
Mia-Cross
force-pushed
the
tests_bump_go_vcr_to_v3
branch
4 times, most recently
from
August 12, 2025 18:10
0ae9b33 to
8f72ace
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #4909 +/- ##
===========================================
- Coverage 75.45% 56.27% -19.19%
===========================================
Files 202 308 +106
Lines 44323 77924 +33601
===========================================
+ Hits 33444 43850 +10406
- Misses 9653 32663 +23010
- Partials 1226 1411 +185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mia-Cross
force-pushed
the
tests_bump_go_vcr_to_v3
branch
from
August 14, 2025 09:22
eaf798a to
7a193a5
Compare
Mia-Cross
marked this pull request as ready for review
August 19, 2025 09:07
# Conflicts: # go.mod # Conflicts: # internal/namespaces/baremetal/v1/testdata/test-baremetal-list-offer-simple.golden
rdb cassette that drifted again
Mia-Cross
force-pushed
the
tests_bump_go_vcr_to_v3
branch
from
August 21, 2025 08:10
b36e64b to
a8f870d
Compare
remyleone
reviewed
Aug 21, 2025
| @@ -1,41 +1,3 @@ | |||
| --- | |||
Member
There was a problem hiding this comment.
Why this interaction is not preserved?
| @@ -1,44 +1,3 @@ | |||
| --- | |||
| version: 1 | |||
Member
There was a problem hiding this comment.
Why is this interaction not preserved?
remyleone
previously approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-vcrintroduced a very helpfulSkipRequestLatencyoption on the recorder in version 3. This will allow us to replay cassettes a lot faster because interactions will not simulate the requests' duration anymore.This is a breaking change however, and we should re-record all cassettes with the new version.
The following changes had to be made in the tests: