fix: align release build job with CI to fix aarch64 failure#67
Merged
Conversation
…rget aarch64-linux was failing because: 1. Missing sandbox=false caused zig2nix to fail building from source when the FlakeHub cache returned 401 (same fix CI already has) 2. nix build (debug default) has a different dep closure than zigmark-safe; using the same target as CI ensures consistent behaviour Also bumps checkout to v6 to match CI.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the release GitHub Actions workflow’s Nix build configuration with the existing CI workflow to address an aarch64-linux release build failure path (notably when FlakeHub cache access fails and a source build is required).
Changes:
- Updated release workflow to use
actions/checkout@v6(matching CI). - Added
sandbox = falseto the release build job’s Nix configuration (matching CI). - Changed the release build command to explicitly build
.#zigmark-safeand link output toresultto match the expected artifact layout and CI’s target package.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sandbox = falseto the release build job's Nix config — CI has this, release didn't; without it, zig2nix fails to build from source on aarch64-linux when the FlakeHub cache returns 401nix build→nix build .#zigmark-safe -o resultto match what CI builds, avoiding the debug default package's different dep closureactions/checkout@v4→@v6to match CI