Fix #133: Recursively resolve array dimensions in parent objects#296
Open
dyrpsf wants to merge 1 commit intosbmlteam:masterfrom
Open
Fix #133: Recursively resolve array dimensions in parent objects#296dyrpsf wants to merge 1 commit intosbmlteam:masterfrom
dyrpsf wants to merge 1 commit intosbmlteam:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves Issue #133 where array validation incorrectly threw a "not a dimension id" error when a child object (e.g., an
EventAssignment) referenced a dimension defined on its parent (e.g., anEvent).Changes Made
getDimension(String fieldId)inArraysSBasePlugin.java.ListOfDimensions, returningnullif the dimension wasn't defined locally.getParentSBMLObject()), checking theArraysSBasePluginof each parent to recursively resolve the dimension ID.Validation
jsbml-arraysextension package.Resolves #133