Fix #99: Implement getTypeCode() for compat SBase inheritors#293
Open
dyrpsf wants to merge 1 commit intosbmlteam:masterfrom
Open
Fix #99: Implement getTypeCode() for compat SBase inheritors#293dyrpsf wants to merge 1 commit intosbmlteam:masterfrom
dyrpsf wants to merge 1 commit intosbmlteam:masterfrom
Conversation
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves Issue #99 by implementing the
getTypeCode()method for allSBaseinheritors within thelibsbml-compatmodule, returning the appropriate integer constants to mirror the C++ libSBML API.Changes Made
libsbmlConstants.javainterface to house the standardSBML_*integer type codes.getTypeCode()method toSpecies,Compartment,Model,SBMLDocument, andListOfSpecieswithin the compatibility module.org.sbml.jsbml.xml.test.SBML_L2V1Test) inSBMLDocument.javathat was preventing the module from compiling.MessageFormatinListOfSpecies.java.throws XMLStreamExceptiondeclarations on theNoteswrapper methods inCompartment.java.Validation
libsbml-compatmodule.Closes #99