Skip to content

debian: Make a native package - #217

Open
agx wants to merge 1 commit into
samcday:mainfrom
agx:native
Open

agx wants to merge 1 commit into
samcday:mainfrom
agx:native

Conversation

@agx

@agx agx commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Non-native create tarballs plus Debian delta which doesn't fit here, it also will easily have a lower version number than in Debian breaking e.g. package tracking in BengalOS:

https://bengalos-team.pages.debian.net/bengalos-package-tracker

Switching to a native package fixes both.

Summary by CodeRabbit

  • Chores
    • Updated Debian package metadata for version 0.53.0, removing the Debian revision suffix while keeping the distribution and urgency unchanged.
    • Switched the Debian source package format from quilt to native. These changes affect how the package is identified and represented in Debian packaging; no application functionality changes are noted.

Non-native create tarballs plus Debian delta which doesn't fit here,
it also will easily have a lower version number than in Debian breaking
e.g. package tracking in BengalOS:

  https://bengalos-team.pages.debian.net/bengalos-package-tracker

Switching to a native package fixes both.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d78afb8b-8fbe-4c6b-846f-cb0eab055549
📥 Commits

Reviewing files that changed from the base of the PR and between 743321b and e1a0d27.

📒 Files selected for processing: 2
  • debian/changelog
  • debian/source/format

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The Debian changelog version changes from 0.53.0-1 to 0.53.0. The Debian source package format changes from 3.0 (quilt) to 3.0 (native).

Changes: Debian packaging

Layer / File(s) Summary
Package metadata
debian/changelog, debian/source/format
The 0.53.0 changelog version changes to 0.53.0. The source package format changes to 3.0 (native).

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to e1a0d

This change switches the Debian packaging to a native package with a matching revision-free version. No issue that should block merging remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: switching the Debian package to native format.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[High impact] Changes how the Debian package is built and versioned.

Update the release command before merging so the next Debian source release remains buildable.

Findings

  1. P1 Next source release fails ▶

Summary

Switches Debian packaging from 3.0 (quilt) to 3.0 (native) and removes the current version’s Debian revision.

  • Debian builds now treat phrog 0.53.0 as a native package.

Reviews (1) · Last reviewed commit: "debian: Make a native package" · Reviewed by Greptile

Comment thread debian/source/format
@@ -1 +1 @@
3.0 (quilt)
3.0 (native)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Next source release fails

3.0 (native) requires a version without a Debian revision, but cargo xtask bump still passes {}-1 to dch. The next automated release will put that revision back into debian/changelog, causing dpkg-source to reject a source package build. Update the version writer to omit -1 alongside this format change.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant