Repository navigation
fix: use crypto/rand for the retry jitter - #35
Merged
Merged
Conversation
The Bearer scan in CI flags math/rand (weak PRNG rule, CWE-327) and fails the Lint workflow on main. The jitter has no security role, but crypto/rand satisfies the rule without suppressing it. If no randomness is available, the plain backoff is used.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
- Coverage 92.39% 91.37% -1.02%
==========================================
Files 3 3
Lines 171 174 +3
==========================================
+ Hits 158 159 +1
- Misses 7 8 +1
- Partials 6 7 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bearer scan in the Lint workflow fails on
mainsince the retry jitter was added:math/randtriggers the weak PRNG rule (CWE-327) atdispatcher.go:153.crypto/randinstead of suppressing the findinggolangci-lint(0 issues) andbearer scan(no failures) pass locally.