Repository navigation
feat: report delivery failures through OnError - #32
Merged
Merged
Conversation
Delivery errors and non-2xx responses were silently discarded, so a rejected token or a server error produced no output at all. Add an OnError option, called for marshaling failures, network errors and non-2xx responses. It defaults to one line on stderr.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 0.00% 75.90% +75.90%
==========================================
Files 2 2
Lines 76 83 +7
==========================================
+ Hits 0 63 +63
+ Misses 76 16 -60
- Partials 0 4 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
samber
marked this pull request as ready for review
October 13, 2026 15:47
A logging library must not write to stderr unasked. Delivery failures stay observable by setting OnError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivery errors and non-2xx responses were silently discarded: a rejected token or a server error produced no output at all.
OnError func(error)option