Skip to content

fix(ci): update Plasma icons dependency setup - #876

Merged
raininforest merged 1 commit into
mainfrom
bugfix/fix-icon-update
Aug 6, 2026
Merged

fix(ci): update Plasma icons dependency setup#876
raininforest merged 1 commit into
mainfrom
bugfix/fix-icon-update

Conversation

@raininforest

@raininforest raininforest commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator
  • теперь установка выполняется через npm run setup:deps:ci;
  • удалён несовместимый с Lerna 9 lerna bootstrap;
  • генерация запускается через workspace @salutejs/plasma-icons

Summary by CodeRabbit

  • Chores
    • Updated the icon-generation workflow to use the current dependency setup and Android icon generation commands.
    • Simplified the automated process for generating Android icons.

@raininforest raininforest self-assigned this Aug 6, 2026
@raininforest raininforest added the bug Something isn't working label Aug 6, 2026
@raininforest
raininforest requested a review from angirb as a code owner August 6, 2026 07:35
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6095402c-1233-4a35-80d4-6f9fb2bc72ac

📥 Commits

Reviewing files that changed from the base of the PR and between d7b98ad and 9cacd21.

📒 Files selected for processing (1)
  • .github/workflows/generate-icons.yml

📝 Walkthrough

Walkthrough

The icon generation workflow now installs Plasma dependencies with setup:deps:ci and generates Android icons through the @salutejs/plasma-icons workspace.

Changes

Icon generation workflow

Layer / File(s) Summary
Update icon generation commands
.github/workflows/generate-icons.yml
The workflow replaces npm ci, Lerna bootstrap, and prefix-based generation with npm run setup:deps:ci and workspace-targeted npm run generate:android.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: angirb, malilex, serramorec

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the CI dependency setup changes for Plasma icons.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/fix-icon-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@raininforest
raininforest merged commit 6bbd09a into main Aug 6, 2026
19 checks passed
@raininforest
raininforest deleted the bugfix/fix-icon-update branch August 6, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working changelog-skip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants