Conversation
test_requester_disconnect_midflight_leaves_worker_alive was racing against libzmq's redelivery of a buffered reply after DEALER identity change: the 2 s drain would time out, then the follow-up send_recv would receive the redelivered stale reply keyed to "drop-me" instead of the freshly requested "after-reconnect". Send the follow-up first and drain replies until we see the one keyed to the fresh id; redelivery timing is no longer part of the assertion path. test_requester_churn_fd_bounded stalled at "warm0" because the fake worker REP had connected but not yet completed its ROUTER<->DEALER handshake with the proxy's inner DEALER when the first REQ arrived, so the request sat in the DEALER's queue with no routable peer. Warm the pipeline with a probe round-trip before the churn loop so the worker is a registered peer of the inner DEALER; the FD-bound assertions run against a live pipeline as intended.
dwoz
force-pushed
the
dwoz/fix/3008x-stress-tests-branch-build
branch
from
September 25, 2026 22:53
410727e to
7c6d4bd
Compare
twangboy
approved these changes
Sep 25, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_requester_disconnect_midflight_leaves_worker_alive was racing against libzmq's redelivery of a buffered reply after DEALER identity change: the 2 s drain would time out, then the follow-up send_recv would receive the redelivered stale reply keyed to "drop-me" instead of the freshly requested "after-reconnect". Send the follow-up first and drain replies until we see the one keyed to the fresh id; redelivery timing is no longer part of the assertion path.
test_requester_churn_fd_bounded stalled at "warm0" because the fake worker REP had connected but not yet completed its ROUTER<->DEALER handshake with the proxy's inner DEALER when the first REQ arrived, so the request sat in the DEALER's queue with no routable peer. Warm the pipeline with a probe round-trip before the churn loop so the worker is a registered peer of the inner DEALER; the FD-bound assertions run against a live pipeline as intended.