Skip to content

Stabilize testsuite - #70282

Open
m-czernek wants to merge 2 commits into
saltstack:3008.xfrom
m-czernek:testsuite-stabilization
Open

Stabilize testsuite#70282
m-czernek wants to merge 2 commits into
saltstack:3008.xfrom
m-czernek:testsuite-stabilization

Conversation

@m-czernek

@m-czernek m-czernek commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

In this PR, I'm porting two test fixes:

tests/pytests/functional/states/pkgrepo/test_suse.py:

  • Old SLE 15 SP4 repo had an expired GPG key.
  • Changed order means that SUSE OSes that are neither TW nor Leap/SLE 15 will get a default repository definition.

tests/pytests/functional/states/test_user.py:

  • There's a difference in how SLE and Leap 15 behaves when creating a new user. On Leap 15, a new user has the $username default group. On SLE 15, it has the users default group.
[mczernek@t14s opensuse-salt (pytest-fix)] $ podman run --rm -it registry.opensuse.org/opensuse/leap:15.6
4859475c9388:/ # useradd test && id test
uid=1000(test) gid=1000(test) groups=1000(test)
[mczernek@t14s opensuse-salt (pytest-fix)] $ podman run --rm -it registry.suse.com/bci/bci-base:15.6
ba904b0c4fc4:/ # useradd test && id test
uid=1000(test) gid=100(users) groups=100(users)

Previous Behavior

Tests would fail under specific SUSE OSes

New Behavior

Tests pass

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Reordering of matching means all SUSE OSes
get a default match repo match in SLS

@m-czernek
m-czernek requested a review from a team as a code owner September 14, 2026 10:52
@m-czernek m-czernek changed the title Fix repo URL that had expired gpg key Stabilize testsuite Sep 14, 2026
@m-czernek
Fix repo URL that had expired gpg key
e07f0c2 
Reordering of matching means all SUSE OSes
get a default match repo match in SLS
@m-czernek
Fix behavior on SUSE vs openSUSE systems
06b2de8 
Leap 15.6 uses $username(1000) as the default group,
but SLE 15.6 uses users(100).

SLE 16+ and Leap 16+ use `$username(1000)` only.
@m-czernek
m-czernek force-pushed the testsuite-stabilization branch from ec8b265 to 06b2de8 Compare September 14, 2026 10:57
@m-czernek m-czernek mentioned this pull request Sep 14, 2026
Merged
3 tasks
@twangboy twangboy added the test:full Run the full test suite label Sep 23, 2026
@twangboy twangboy added this to the Argon v3008.3 milestone Sep 23, 2026

This branch was successfully deployed

1 active deployment
ci — 06b2de86 Deployed Sep 23, 2026 by twangboy via Build Onedir Packages / DEB (arm64) #27218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twangboy twangboy twangboy approved these changes

Assignees

No one assigned

Labels

test:full Run the full test suite

Projects

None yet

Milestone

Argon v3008.3

Development

Successfully merging this pull request may close these issues.

2 participants

@m-czernek @twangboy