Conversation
themavik
left a comment
themavik
left a comment
There was a problem hiding this comment.
Reviewed the changes — the fix looks correct and follows the existing code patterns.
|
Looks like psycopg2 is difficult to build on 32bit Windows. The last version of psycopg2-binary that had a 32bit Windows build was 2.9.10. That's why it's failing to build. |
The salt_onedir step calls `git add -f salt/_version.txt` with
`cwd=str(salt_archive)`, but `salt_archive` is a path to a `.tar.gz`
file, not a directory. Python's subprocess implementation calls
`chdir()` on `cwd` and raises:
NotADirectoryError: [Errno 20] Not a directory:
'/.../salt-3008.0+NNN.gSHA.tar.gz'
This blocks the Build Salt Onedir job on Linux and macOS, which in
turn cascades to every dependent Build Onedir Packages job.
Use `tools.utils.REPO_ROOT` instead so the subprocess runs in the
salt source checkout, which is a real git repository containing
`salt/_version.txt`. This mirrors the fix already landed on master
in commit eba196e.
|
I'm looking to help out with the feature from #67720 . It looks like this might be related, but it seems like its only the options to the pillar. Is the rest of the work already done and you're establishing the configuration api? Or is there more work to be done here? I'm just looking for how I can help, because mTLS would be a really nice addition. I do not know if this will enable mTLS for the postgres execution module or if there's additional work intended. I'm just trying to be collaborative and not snipe someone's work. |
This branch was previously deployed
5 participants
Rebase of #67721