fix(acp): preserve setup prerequisites and runtime path editing - #196
Merged
Conversation
Keep wizard probes tied to the current selection and path, honor bundled runtimes, and validate runtime overrides before testing or saving. Preserve the native path editor while stale probe results are invalidated. Add a Debug Skia gate that types through the real control. Verify it fails on the first character when the former visibility rule is restored and passes after rebuilding the fix. Refs #195
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP 安装向导在重新选择 Agent、编辑程序路径或取消检测时，可能保留旧探测结论、把自带运行时的适配器挡在“下一步”，或让路径输入框在首字输入后消失。本 PR 让步骤门控和探测结果按当前选择与路径生效，保留编辑入口，并在忙碌期间换选适配器后补做当前选择的探测。
Claude/Codex npm 适配器使用目录声明的内置运行时能力；显式选择独立运行时时，同一个启动计划把路径传给适配器约定的环境变量。测试和保存共用校验：Claude 适配器无法启动的 Windows 批处理路径会显示本地化改正提示，不启动测试进程也不写配置；普通 POSIX 路径和 Codex 的已声明路径语义保持可用。
验证：完整 Presentation 3593/3593、Infrastructure 的 AcpSetup 160/160、Application 的 AcpSetup 28/28，全部零跳过。新增回归覆盖扫描前后选择、选择/路径往返、取消、忙时换选、保存失败后改正，以及逐字编辑。桌面 Debug 构建通过；新 Xvfb/XTest 门禁从正式设置入口进入真实缺失 Qwen 的向导，44 次实际键盘采样通过，门禁已接 CI。反向验证临时恢复旧可见性后，首字采样即失败；恢复源码并重编后再次 44/44 通过。最终提交
75e40517的 16 项检查通过、1 项仓库条件检查跳过，包含新输入门禁、真实 WASM 全链、Windows MSIX 打包、Windows ConPTY 和各平台构建。基线为 main
cab0a410。官方行为依据固定在 Claude Agent ACP 0.76.0 与 Codex ACP 1.11.0 的源码注释；未执行真实第三方登录，也不把 Linux 输入门禁当作 Windows 安装包 GUI 验收。Refs #195。门禁实现说明：Debug driver 保持单一方法作用域，以同一个 finally 覆盖导航超时、输入断言失败与事件解绑；因此按代码规范的明确例外保留超过 60 行的方法。它不会进入 Release 行为；采样期间不回写文本、不恢复焦点或展开状态。