Cash reward redemption by 00salmon · Pull Request #490 · saasquatch/program-tools

Sam Beveridge (00salmon) · 2026-04-06T21:09:27Z

Description of the change

Description here

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation or Development tools (readme, specs, tests, code formatting)

Links

Jira issue number: (PUT IT HERE)
Process.st launch checklist: (PUT IT HERE)

Checklists

Development

Prettier was run (if applicable)
The behaviour changes in the pull request are covered by specs
All tests related to the changed code pass in development

Paperwork

This pull request has a descriptive title and information useful to a reviewer
This pull request has a Jira number
This pull request has a Process.st launch checklist

Code review

Changes have been reviewed by at least one other engineer
Security impacts of this change have been considered

…o cash-reward-redemption

Copilot

Pull request overview

This PR enhances the Tax & Cash banking info form by introducing structured, per-field validation error handling based on Impact API validation metadata, and adds a new “Partner Info Modal” component to the Mint component library/stencilbook.

Changes:

Map backend validation errors (field + errorPath) to form field names and frontend-friendly error codes.
Add configurable per-field ICU error-message templates and wire them into form validation rendering.
Introduce a new sqm-partner-info-modal component (view + stories) and register it in the stencilbook; bump package version.

Reviewed changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
packages/mint-components/src/components/tax-and-cash/sqm-banking-info-form/useBankingInfoForm.tsx	Adds API→form field/error-code mapping and includes `errorPath` in GraphQL validationErrors.
packages/mint-components/src/components/tax-and-cash/sqm-banking-info-form/sqm-banking-info-form.tsx	Adds per-field error message props + ICU templates and renders richer invalid messages when an API errorCode is present.
packages/mint-components/src/components/tax-and-cash/sqm-banking-info-form/sqm-banking-info-form-view.tsx	Extends form error shape to include `errorCode` and adds `text.errorMessages`.
packages/mint-components/src/components/tax-and-cash/sqm-banking-info-form/formDefinitions.tsx	Passes `errorCode` + `fieldName` into validation message builder for each form input.
packages/mint-components/src/components/tax-and-cash/sqm-banking-info-form/readme.md	Documents the newly added per-field error-message props.
packages/mint-components/src/components/sqm-stencilbook/sqm-stencilbook.tsx	Registers Partner Info Modal stories in the stencilbook.
packages/mint-components/src/components/sqm-partner-info-modal/sqm-partner-info-modal.tsx	Adds new Partner Info Modal component (currently demo-hook driven).
packages/mint-components/src/components/sqm-partner-info-modal/sqm-partner-info-modal-view.tsx	Implements the modal UI (dialog + selects + submit button).
packages/mint-components/src/components/sqm-partner-info-modal/PartnerInfoModal.stories.tsx	Adds Storybook stories for the Partner Info Modal.
packages/mint-components/src/components.d.ts	Updates generated component typings for new/updated props and new component.
packages/mint-components/package.json	Bumps package version to `2.1.8-0`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-06T21:34:44Z

        const mappedValidationErrors = validationErrors?.reduce(
          (agg, error) => {
+            const formField =
+              API_FIELD_TO_FORM_FIELD[error.field] || error.field;
+            const errorCode =
+              API_ERROR_PATH_TO_FRONTEND[error.errorPath] || error.errorPath;
            return {
              ...agg,
-
-              [error.field]: {
+              [formField]: {
                type: "invalid",
+                errorCode,
              },


errorCode falls back to error.errorPath, but the UI templates’ other branch is documented to display the raw API message. Falling back to the dot-delimited path will surface non-user-friendly strings like withdrawal.settings.error.routingcode in the UI. Consider using error.message as the fallback display value (or pass both a stable code and a human message separately).

Copilot · 2026-04-06T21:34:45Z

            helpText: getValidationErrorMessage({
              type: errors?.inputErrors?.beneficiaryTaxPayerId?.type,
              label: props.text.taxPayerIdLabel,
+              errorCode: errors?.inputErrors?.taxPayerId?.errorCode,


The Tax Payer ID field’s error helper reads errors?.inputErrors?.taxPayerId?.errorCode, but the error being checked is errors?.inputErrors?.beneficiaryTaxPayerId. This prevents the specific API errorCode from being shown for this field. Use the same key (beneficiaryTaxPayerId) when reading errorCode (while still using fieldName: "taxPayerId" if you intend to select the taxPayerId template).

Suggested change

errorCode: errors?.inputErrors?.taxPayerId?.errorCode,

errorCode: errors?.inputErrors?.beneficiaryTaxPayerId?.errorCode,

…h/program-tools into cash-reward-redemption

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…eUserInfoForm and useTaxAndCash step logic. Handle Impact API sending back DZ and 000000 for phone number data

…h/program-tools into cash-reward-redemption

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

… partner creation in to widget verificaiton flow. Some view refactors for all 3 components

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 21 out of 23 changed files in this pull request and generated 12 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-14T18:45:08Z

+            const formField =
+              API_FIELD_TO_FORM_FIELD[error.field] || error.field;
+            const errorCode =
+              API_ERROR_PATH_TO_FRONTEND[error.errorPath] || error.errorPath;
            return {
              ...agg,
-
-              [error.field]: {
+              [formField]: {
                type: "invalid",
+                errorCode,
              },
            };


The fallback for unknown API error codes uses error.errorPath as the displayed errorCode. Even after fixing the field name, the error “code/path” strings aren’t user-friendly, while the API already provides a human-readable message. Consider storing both a short mapped errorCode (for ICU select) and a separate errorMessage fallback (or use message as the other branch value) so the UI doesn’t show internal code strings to end users.

Copilot · 2026-04-14T18:45:09Z

+  // Early partner creation does not collect these fields
+  if (
+    !billingAddress ||
+    !billingCity ||
+    !billingPostalCode ||
+    !billingState ||
+    !phoneNumber
+  ) {
+    return "/1";
+  }


getCurrentStep treats any non-empty phoneNumber as “present”, but elsewhere in this PR the Impact placeholder value ("0000000") is treated as “missing” and cleared for the form. As written, a placeholder phone number will bypass the “missing fields” redirect and advance the flow incorrectly. Consider treating the placeholder value as missing here as well (and ideally centralize this sentinel handling so it’s consistent across the flow).

Copilot · 2026-04-14T18:45:09Z

+            ? null
+            : user.impactConnection.publisher.phoneNumberCountryCode,
+        phoneNumber:
+          user.impactConnection.publisher.phoneNumber === "0000000"
+            ? null


setUserFormContext sets phoneNumber / phoneNumberCountryCode to null when the placeholder is detected. In this codebase, the form view props for these fields are typed as string | undefined, and web components like sl-input/sl-select typically expect a string value. Use an empty string or undefined for “no value” to avoid passing null into input value props and to keep downstream payload building consistent.

Suggested change

? null

: user.impactConnection.publisher.phoneNumberCountryCode,

phoneNumber:

user.impactConnection.publisher.phoneNumber === "0000000"

? null

? undefined

: user.impactConnection.publisher.phoneNumberCountryCode,

phoneNumber:

user.impactConnection.publisher.phoneNumber === "0000000"

? undefined

Copilot · 2026-04-14T18:45:10Z

        const mappedValidationErrors = validationErrors?.reduce(
          (agg, error) => {
+            const formField =
+              API_FIELD_TO_FORM_FIELD[error.field] || error.field;
+            const errorCode =
+              API_ERROR_PATH_TO_FRONTEND[error.errorPath] || error.errorPath;
            return {
              ...agg,
-
-              [error.field]: {
+              [formField]: {
                type: "invalid",
+                errorCode,
              },


validationErrors are queried with a code field (see the GraphQL documents above), but the TypeScript result types and mapping logic expect errorPath (error.errorPath). This means errorCode will be undefined at runtime and the per-field ICU error messages won’t resolve correctly. Update the result types and mapping to use the actual response field name (or query the field you intend to use) and ensure the reducer reads that same property consistently.

Copilot · 2026-04-14T18:45:11Z

+              errorCode: errors?.inputErrors?.taxPayerId?.errorCode,
+              fieldName: "taxPayerId",


For the beneficiaryTaxPayerId field, the error type is read from errors.inputErrors.beneficiaryTaxPayerId, but the new errorCode is read from errors.inputErrors.taxPayerId. This mismatch will prevent the correct per-field error message from being selected. Use the same key consistently (likely beneficiaryTaxPayerId) for both type and errorCode.

Suggested change

errorCode: errors?.inputErrors?.taxPayerId?.errorCode,

fieldName: "taxPayerId",

errorCode: errors?.inputErrors?.beneficiaryTaxPayerId?.errorCode,

fieldName: "beneficiaryTaxPayerId",

…ctPartner mutation

Copilot

Pull request overview

Copilot reviewed 22 out of 24 changed files in this pull request and generated 12 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-15T23:58:33Z

+    validationErrors: {
+      field: string;
+      message: string;
+      errorPath: string;
+    }[];


validationErrors is typed with an errorPath field, but the GraphQL mutations in this file request validationErrors { code }. This mismatch will cause the new error-code mapping to see undefined at runtime. Update the TypeScript result types to match the actual response shape (or request the correct field).

Copilot · 2026-04-15T23:58:34Z

+      const vars = {
+        user: {
+          id: user.id,
+          accountId: user.accountId,
+        },
+        firstName: user.firstName,


onSubmit constructs vars using user.id/accountId/firstName/lastName without verifying user is defined. Since showModal only checks userLoading (not user), the modal can be interactive even if user is missing, leading to a crash. Add a guard (and surface networkErrorText if user data is unavailable).

Copilot · 2026-04-15T23:58:34Z

      validationErrors {
        field
        message
+        code
      }


The mutation requests validationErrors { code }, but downstream logic reads errorPath. Either request errorPath from the API (if supported) or switch the mapping logic/types to use code consistently.

Copilot · 2026-04-15T23:58:35Z

+  console.log(states, "partner info modal states"); // TEMP
+


Remove the temporary console.log debug statement before merging. Leaving this in a production component will spam logs and may expose internal state.

Suggested change

console.log(states, "partner info modal states"); // TEMP

Copilot · 2026-04-15T23:58:35Z

+            const formField =
+              API_FIELD_TO_FORM_FIELD[error.field] || error.field;
+            const errorCode =
+              API_ERROR_PATH_TO_FRONTEND[error.errorPath] || error.errorPath;


The error mapping uses error.errorPath, but the mutations request validationErrors { code }. As a result errorCode will be undefined and the per-field ICU error messages won’t be used. Use the actual field returned by the API (e.g., error.code) when computing errorCode.

Suggested change

API_ERROR_PATH_TO_FRONTEND[error.errorPath] || error.errorPath;

API_ERROR_PATH_TO_FRONTEND[error.code] || error.code;

Copilot · 2026-04-15T23:58:35Z

+        // when creating an impact connection without sending phoneNumber data, the impactAPI defaults the value to "000000" and the phoneNumberCountryCode to "DZ"
        phoneNumberCountryCode:
-          user.impactConnection.publisher.phoneNumberCountryCode,
-        phoneNumber: user.impactConnection.publisher.phoneNumber,
+          user.impactConnection.publisher.phoneNumber === "0000000"
+            ? null
+            : user.impactConnection.publisher.phoneNumberCountryCode,
+        phoneNumber:
+          user.impactConnection.publisher.phoneNumber === "0000000"
+            ? null
+            : user.impactConnection.publisher.phoneNumber,


The comment says Impact defaults missing phone numbers to "000000", but the code checks for "0000000". This inconsistency likely prevents the placeholder value from being normalized to null as intended. Use the correct placeholder value (and consider centralizing it as a constant so it’s consistent across the codebase).

Copilot · 2026-04-15T23:58:35Z

+    );
+  }, [financeNetworkData, currenciesData, countryCode]);
+
+  console.log(countryCode, currency, "initial country and currency state"); // TEMP


Remove the temporary console.log debugging statements before merging (e.g., logging initial country/currency and other internal state). These create noisy production logs and can leak user-related information.

Suggested change

console.log(countryCode, currency, "initial country and currency state"); // TEMP

…o handle country that has states.

Derek Siemens (DerekSiemens) and others added 6 commits March 2, 2026 16:51

DS: Initial vibe coded approach for better error messages

f9e4f00

DS: update hooks for error path

15a30f7

Merge branch 'master' into banking-validation

4170604

Add sqm-partner-info-modal

2fdaf6e

publish pre-release

2710f9c

Merge remote-tracking branch 'origin/cash-reward-redemption-andy' int…

bebaa7a

…o cash-reward-redemption

Copilot AI review requested due to automatic review settings April 6, 2026 21:09

Copilot started reviewing on behalf of Sam Beveridge (00salmon) April 6, 2026 21:10 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

Sam Beveridge (00salmon) and others added 3 commits April 7, 2026 08:55

cleaning up over-explained comments

561c2a7

Create usePartnerInfoModal and modify view/controller

0b82626

Merge branch 'cash-reward-redemption' of https://github.com/saasquatc…

421951e

…h/program-tools into cash-reward-redemption

Copilot AI review requested due to automatic review settings April 7, 2026 17:09

Copilot started reviewing on behalf of AndiLuo April 7, 2026 17:10 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

Sam Beveridge (00salmon) and others added 3 commits April 7, 2026 13:53

update query to match backend schema

f08069c

Update usePartnerInfoModal. Update views for partner modal. Update us…

df46543

…eUserInfoForm and useTaxAndCash step logic. Handle Impact API sending back DZ and 000000 for phone number data

Merge branch 'cash-reward-redemption' of https://github.com/saasquatc…

baaf3c7

…h/program-tools into cash-reward-redemption

Copilot AI review requested due to automatic review settings April 9, 2026 00:28

Copilot started reviewing on behalf of AndiLuo April 9, 2026 00:29 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

AndiLuo added 2 commits April 9, 2026 16:33

Add sqm-partner-info-modal to sqm-widget-verification

f169846

Update code/email verification components to live inside modals. Bake…

b094ed3

… partner creation in to widget verificaiton flow. Some view refactors for all 3 components

Copilot AI review requested due to automatic review settings April 10, 2026 23:31

Copilot started reviewing on behalf of AndiLuo April 10, 2026 23:31 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

AndiLuo requested a review from Noah Clarke (noahwc) April 13, 2026 23:05

AndiLuo added 2 commits April 13, 2026 17:10

Fix styling issues for inModal partner creation

437b725

Fix content editor state previews and styling issues

462180f

Copilot AI review requested due to automatic review settings April 14, 2026 18:39

Copilot started reviewing on behalf of AndiLuo April 14, 2026 18:39 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Update useUserInfoForm and useIndirectTaxForm to include completeImpa…

c8f126a

…ctPartner mutation

Noah Clarke (noahwc) reviewed Apr 15, 2026

View reviewed changes

Comment thread packages/mint-components/src/components/sqm-partner-info-modal/sqm-partner-info-modal-view.tsx Outdated

Add currency filtering based on country - similiar to user info form

56dd045

Copilot AI review requested due to automatic review settings April 15, 2026 23:52

Copilot started reviewing on behalf of AndiLuo April 15, 2026 23:52 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Pre-fill country in partner modal based on local. Update step logic t…

c119d46

…o handle country that has states.

	errorCode: errors?.inputErrors?.taxPayerId?.errorCode,
	errorCode: errors?.inputErrors?.beneficiaryTaxPayerId?.errorCode,

		errorCode: errors?.inputErrors?.taxPayerId?.errorCode,
		fieldName: "taxPayerId",

	API_ERROR_PATH_TO_FRONTEND[error.errorPath] \|\| error.errorPath;
	API_ERROR_PATH_TO_FRONTEND[error.code] \|\| error.code;

Conversation

Sam Beveridge (00salmon) commented Apr 6, 2026

Description of the change

Type of change

Links

Checklists

Development

Paperwork

Code review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment