fix(ci): correct dependency watch terminal state#217
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee91f18ccf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if readback_required and not readback_verified: | ||
| raise SystemExit("dependency issue destination readback was not verified") | ||
| PY | ||
| run: python3 .github/scripts/dependency_watch_completion.py |
There was a problem hiding this comment.
Update the contract checker for the extracted emitter
This repo's scripts/ci/check-dependency-watch-contract.mjs still reads only .github/workflows/dependency-watch.yml and requires the AutomationTerminalStateV1 marker plus the partial = issue_attempted and not readback_verified formula; after this line delegates to the new Python file, those strings are no longer in the workflow. I ran node scripts/ci/check-dependency-watch-contract.mjs and it now fails with dependency-watch contract missing: machine completion state, partial mutation accounting, so pnpm check:dependency-watch-contract/health:repo:checks is blocked until the checker is updated to inspect the extracted script or the workflow keeps those contract markers.
Useful? React with 👍 / 👎.
What
Why
The scheduled dependency-watch run produced an invalid terminal receipt, so the global automation freshness checker could not accept it as qualifying burn-in evidence.
How
The workflow now passes collected audit results to .github/scripts/dependency_watch_completion.py, which computes the canonical status and readback shape without changing dependency scanning behavior.
Testing
Performance impact
No frontend or runtime code changes. Bundle-size gate passed. The required local build-time comparison remains non-green and noisy: observed +23.74%, +15.82%, +59.89%, and +68.26% against the stored 15% threshold. This PR must not be merged until that required gate is green or its baseline is separately and legitimately dispositioned.
Risks
Lockfile rationale
No lockfiles are included in this PR. Existing unrelated lockfile changes remain uncommitted in the local checkout.
Screenshots
Not applicable; no UI changes.