Fixed a bug that duplicated items. (Slowed + Reverb)#966
Open
lap2ka wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the block-assembly/move logic to reduce item duplication when assembling containers or other block entities that can hold items but don’t implement Clearable (referenced by Issue #170 and the earlier fix in PR #951).
Changes:
- When moving blocks, clears contents for
Clearableblock entities as before. - Adds a fallback path for non-
Clearableblock entities: if an NBT tag exists, reloads the source block entity from an emptyCompoundTagbefore the old block is destroyed, aiming to prevent duplicate drops/state retention.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
This bug allowed me to make great things like https://discord.com/channels/937435293294919690/937435293294919694/1506431036932755598 Safe to say it will be dearly missed |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #170
Slows and reverbs #951