Skip to content

Fixed a bug that duplicated items. #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yansunsky wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixed a bug that duplicated items. #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e628b73
"Fixed a bug that duplicated items. The bug was: when an item was pla…
yansunsky May 19, 2026
c39440f
A more concise method
yansunsky May 20, 2026
859d28f
A more concise method
yansunsky May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions common/src/main/java/dev/ryanhcode/sable/api/SubLevelAssemblyHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,8 @@ public static void moveBlocks(final ServerLevel level, final AssemblyTransform t
}
if (blockEntity instanceof final Clearable clearable) {
clearable.clearContent();
}else if (blockEntity != null) {
SableAssemblyPlatform.INSTANCE.clearNonClearableContainerItems(blockEntity,tag);
}

final LevelChunk chunk = resultingAccelerator.getChunk(SectionPos.blockToSectionCoord(newPos.getX()), SectionPos.blockToSectionCoord(newPos.getZ()));
Expand Down
4 changes: 4 additions & 0 deletions common/src/main/java/dev/ryanhcode/sable/platform/SableAssemblyPlatform.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
package dev.ryanhcode.sable.platform;

import net.minecraft.nbt.CompoundTag;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.block.entity.BlockEntity;
import org.jetbrains.annotations.ApiStatus;

@ApiStatus.Internal
public interface SableAssemblyPlatform {
SableAssemblyPlatform INSTANCE = SablePlatformUtil.load(SableAssemblyPlatform.class);

void setIgnoreOnPlace(final Level level, final boolean ignore);

void clearNonClearableContainerItems(final BlockEntity blockEntity,final CompoundTag tag);
}
14 changes: 14 additions & 0 deletions fabric/src/main/java/dev/ryanhcode/sable/fabric/platform/SableAssemblyPlatformImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

import dev.ryanhcode.sable.fabric.mixinterface.LevelExtension;
import dev.ryanhcode.sable.platform.SableAssemblyPlatform;
import net.minecraft.nbt.CompoundTag;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.block.entity.BlockEntity;
import org.jetbrains.annotations.ApiStatus;

@ApiStatus.Internal
Expand All @@ -12,4 +14,16 @@ public class SableAssemblyPlatformImpl implements SableAssemblyPlatform {
public void setIgnoreOnPlace(final Level level, final boolean ignore) {
((LevelExtension) level).sable$setIgnoreOnPlace(ignore);
}

@Override
public void clearNonClearableContainerItems(final BlockEntity blockEntity,final CompoundTag tag) {
try {
final Level level = blockEntity.getLevel();
if (level == null) return;
final String id = tag.getString("id");
final CompoundTag newTag = new CompoundTag();
newTag.putString("id", id);
blockEntity.loadWithComponents(newTag, level.registryAccess());
} catch (final Exception ignored) {}
}
}
14 changes: 14 additions & 0 deletions neoforge/src/main/java/dev/ryanhcode/sable/neoforge/platform/SableAssemblyPlatformImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
package dev.ryanhcode.sable.neoforge.platform;

import dev.ryanhcode.sable.platform.SableAssemblyPlatform;
import net.minecraft.nbt.CompoundTag;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.block.entity.BlockEntity;
import org.jetbrains.annotations.ApiStatus;

@ApiStatus.Internal
Expand All @@ -11,4 +13,16 @@ public class SableAssemblyPlatformImpl implements SableAssemblyPlatform {
public void setIgnoreOnPlace(final Level level, final boolean ignore) {
level.captureBlockSnapshots = ignore;
}

@Override
public void clearNonClearableContainerItems(final BlockEntity blockEntity,final CompoundTag tag) {
try {
final Level level = blockEntity.getLevel();
if (level == null) return;
final String id = tag.getString("id");
final CompoundTag newTag = new CompoundTag();
newTag.putString("id", id);
blockEntity.loadWithComponents(newTag, level.registryAccess());
} catch (final Exception ignored) {}
}
}