Fix crash caused by teleporting using Iron's Teleport scroll#700
Open
gjorgdy wants to merge 2 commits into
Open
Fix crash caused by teleporting using Iron's Teleport scroll#700gjorgdy wants to merge 2 commits into
gjorgdy wants to merge 2 commits into
Conversation
|
|
This was referenced May 2, 2026
…d to the plot grid of an unloaded sublevel
|
Is there a reason why your PR is for main rather than your feature/irons-compat branch? In my brief testing I was able to teleport without issue using a build based off of that branch, including with portal frames. It seems that it is a better fix for this issue. I'm planning on testing it on a server with around 8 players over the next few days and would be happy to report any feedback if it is wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mixin for player teleportation did not cover all possible teleport methods the class contains. One of these methods which was not covered is called by Iron's Spells and Spellbooks to teleport using the teleport and the portal spells.
A small other issue still persists, portal frames only being to teleport players to sublevels, but not detecting player collision when the frame is in a sublevel. I am not quite sure if this is an issue caused by Iron's or by Sable at this moment.
Closes #496