Repository navigation
Limit Apple shell updates to displayed state - #2803
Open
AlexSchmidt1999 wants to merge 1 commit into
Open
AlexSchmidt1999 wants to merge 1 commit into
AlexSchmidt1999 wants to merge 1 commit into
Conversation
This was referenced Oct 16, 2026
Author
|
I am using NOOP 12.1.0 Release build 456 on my iPhone 17 Pro Max, and the app runs very smoothly in everyday use. This PR is included in that combined build, together with my other Apple changes and the performance fixes from #2724 by @UtkuDenizAltiok and #2705 by @kavemang. The installed source is d67cceb5. Both Apple builds and the local app, analytics, database and Python test suites passed for this combined build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live heart-rate updates currently invalidate the Apple app scene because it owns
AppModelthroughStateObject. The scene now retains the same model inState, while screens and live leaves keep their existing observations. The iPhone tab shell receives its repository as an action reference. A small observed modifier handles the Shortcuts import confirmation, including imports staged before the alert mounts.This carries the app-shell change from the owner's installed 12.1 build into its own upstream PR. The hosted macOS tests cover pulse updates at the leaf, stable owner evaluation, cancellation, and confirmation writing the prepared import. Each fixture opens its private store before creating the app model.
The iPhone timing report records the combined build in everyday use. The code changes Apple observation ownership; analytics, storage formats and Android behavior stay the same. Existing SwiftUI components and design tokens are retained.
Installed-source update, October 16
The shared shell call sites match the installed build, including the observed Shortcuts confirmation and its private-store test fixtures.
Review head:
7ff61b6523c6. A local merge of the PRs reproduces the installed iPhone commitf88a1e12: 1,182 of 1,183 Apple product files are byte-identical; the remaining file uses the existingNoopMetrics.space3token for the same 12-point spacing. The combined macOS build and iPhone Release build pass, including widgets and Watch components. The macOS run completes 2,352 app tests with three skipped and zero failures.